LRWebSocketConnection should listen for any socket errors

[compulim]

Background

LRWebSocketConnection should listen for any socket errors, otherwise, when the underlying socket emit error event due to TCP error, it will quit the host process.

Sample scenario

The code below will crash livereload-server instantly

!function (WebSocket) {
    var ws = new WebSocket('ws://localhost:35729/livereload');

    ws.on('open', function () {
        process.exit(0);
    });
}(require('ws'));

It will crash with the following error.

events.js:85
      throw er; // Unhandled 'error' event
            ^
Error: read ECONNRESET
    at exports._errnoException (util.js:746:11)
    at TCP.onread (net.js:559:26)

[compulim]

Ping.

[yuki-takei]

Override _createConnection

const LRWebSocketServer = require('livereload-server/lib/server');

/**
* prevent to crash socket with:
* -------------------------------------------------
* Error: read ECONNRESET
*     at exports._errnoException (util.js:1022:11)
*     at TCP.onread (net.js:569:26)
* -------------------------------------------------
*
* @see https://github.com/napcs/node-livereload/pull/15
*
*/
hackLRWebSocketServer() {
  const orgCreateConnection = LRWebSocketServer.prototype._createConnection;

  // replace https://github.com/livereload/livereload-server/blob/v0.2.3/lib/server.coffee#L74
  LRWebSocketServer.prototype._createConnection = function(socket) {
    // call original method with substituting 'this' obj
    orgCreateConnection.call(this, socket);

    socket.on('error', (err) => {
      console.warn(`[WARN] Worthless error in client socket: '${err}'`);
    });
  }
}