.github: Only tag images as latest for tags #890
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only want to release "latest" images* when we are doing a release, not on every main build. We have already changed staging to deploy from the `-main` tags so it stays up to date with main, but we only want prod to use a stable tag. Prod also includes public Os, which should definitely only deploy images that have been thoroughly tested and tagged as a release. * Keep in mind we're not referring to literally `latest` docker tags, because we use the same docker repository for multiple pipelines. So for example, it's more like live-app-streamdiffusion being the latest for the streamdiffusion pipelines.
victorges
force-pushed
the
chore/latest-tag-fix
branch
from
9163d11 to
7fc4954
Compare
Contributor
Author
|
FTR whoever takes over this, you might want to check this |
Contributor
Author
|
For reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only want to release "latest" images* when
we are doing a release, not on every main build.
We have already changed staging to deploy from the
-maintags so it stays up to date with main, but we only want prod to use a stable tag. Prod alsoincludes public Os, which should definitely only
deploy images that have been thoroughly tested and tagged as a release.
latestdocker tags, because we use the same docker repository for multiple pipelines. So for example, it's more like live-app-streamdiffusion being thelatest for the streamdiffusion pipelines.