feat!: remove icc file after processing #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- "--load" flag addresses the following warning: No output specified for docker-container driver. Build result will only remain in the build cache. To push result image into registry use --push or to load image into docker use --load - "buildx" explicitly uses buildx, to respect the builder chosen as default (by docker buildx use <builder_name>)
Long term we intend to perform colour profile adjustment in-memory and leave no leftovers after processing.
…ting garbage - Vips processor required moving the srgb conversion to a different location, because it only reads source file lazily, on attempt to write. - jpgicc leaves empty file on failure (and it happens to fail on grayscale, thus the shared examples are in two places)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
At the beginning of image processing, Morandi applies the colour profile and saves the file with a
.icc.jpgextension. That file never gets removed and pollutes the disk.Changes made
path.iccto set an srgb location; ultimately, colourspace transformation should be performed in memory to make processing faster.icc.jpgfile after processingbuildx