Skip to content

Rename log field pID to participantID#860

Merged
paulwe merged 2 commits intomainfrom
rename-pID-to-participantID
Mar 15, 2026
Merged

Rename log field pID to participantID#860
paulwe merged 2 commits intomainfrom
rename-pID-to-participantID

Conversation

@paulwe
Copy link
Copy Markdown
Contributor

@paulwe paulwe commented Mar 15, 2026

Summary

  • Rename all occurrences of the "pID" log field to "participantID" for consistency across repos

Test plan

  • Verify logs emit participantID instead of pID

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Comment thread localparticipant.go Outdated
writer := newByteStreamWriter(info, header, p.engine, options.DestinationIdentities, options.OnProgress)

p.engine.OnClose(func() {
// XXX
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

claude adding random stuff

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, that's me...

@paulwe paulwe merged commit b09b583 into main Mar 15, 2026
5 checks passed
@paulwe paulwe deleted the rename-pID-to-participantID branch March 15, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants