Conversation
anunaym14
reviewed
Aug 26, 2025
Member
anunaym14
left a comment
anunaym14
left a comment
There was a problem hiding this comment.
LGTM, small nits in the comment!
Comment on lines
+70
to
73
| transport := p.getPublishTransport() | ||
| if transport == nil { | ||
| return nil, ErrNoPeerConnection | ||
| } |
Member
There was a problem hiding this comment.
The lack of transport should be handled internally right?
Contributor
Author
There was a problem hiding this comment.
Probably. But, I am not changing behaviour here.
Member
There was a problem hiding this comment.
Yeah, it's not from this PR, but something we can make a note of for v3
| PublishTracks: publishedTracks, | ||
| DataChannels: dataChannels, | ||
| TrackSidsDisabled: trackSidsDisabled, | ||
| // MIGRATION-TODO DatachannelReceiveStates |
Member
There was a problem hiding this comment.
Pending TODO, just wanted to highlight it
Contributor
Author
There was a problem hiding this comment.
Yeah, I added it for attention later.
anunaym14
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conditioned on version >= 3.0.0
Tested by manually setting version to 3.0.0 and doing the publish demo using lk cli.