-
Notifications
You must be signed in to change notification settings - Fork 121
feat(whatsapp): add disconnect reason field for disconnect request #1341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1843af1
feat(whatsapp): add user_disconnected field for disconnect request
anunaym14 0857203
generated protobuf
github-actions[bot] 7713178
use enum
anunaym14 acc598b
generated protobuf
github-actions[bot] 385f552
Create sixty-years-occur.md
anunaym14 716a182
update comment
anunaym14 b38e187
generated protobuf
github-actions[bot] a2d1c64
Update protobufs/livekit_connector_whatsapp.proto
anunaym14 9a4eb7d
generated protobuf
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@livekit/protocol": patch | ||
| --- | ||
|
|
||
| feat(whatsapp): add disconnect reason field for disconnect request |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already imports livekit_models.proto indirectly through livekit_rtc.proto, so I guess this does not conflict, but how does this interact with the
DisconnectReasontype there?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/livekit/protocol/pull/1341/files#diff-b03fd2d20c68ec5c91c1c1f2639b328dea367fa8b8e0006843bf05167d9937c7R85-R96
The final name for the embedded enum is different, so it does not conflict. I have verified that the generated code uses the embedded type.