-
Notifications
You must be signed in to change notification settings - Fork 139
feat: add docs to shadcn components #1261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
size-limit report 📦
|
|
how and where are we planning to consume the |
https://github.com/livekit/web/pull/2798 We use it in |
231f668 to
dfce586
Compare
dfce586 to
3abddf0
Compare
1egoman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally makes sense to me. I'm assuming you are holding off on all the argTypes todos for a future pull request?
Ahh good catch, I'll clean that up I had an agent review the stories and make note of the props we weren't being exposed. For instance
|
Summary
doc-gen.tsscript usesreact-docgen-typescriptto extract and output prop types toprop-types.jsonAgentSessionProvider,AgentChatTranscript,AgentChatIndicator,AgentDisconnectButton,StartAudioButton, visualizers, and track controls...propsspread andComponentProps<'element'>types to properly forward HTML attributesRelated to https://github.com/livekit/web/pull/2798
Testing
pnpm registry:buildto verify doc generation worksdist/prop-types.jsoncontains expected component documentation