Skip to content

Conversation

@alexvanyo
Copy link
Collaborator

Fixes #125 .

This is a breaking change to convert current usages of Class to KClass in a couple spots in the API.

This allows the runtime module to be fully multiplatform to setup #81 , as KClass is not specific to jvm targets like Class is.

This was previously part of #78 , but spun out here for ease of reviewing the API change without adjusting the entire project to be multiplatform.

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

🧛 Project Code Coverage: 97.68%

Coverage of Modified Files:

File Coverage
SealedEnum.kt 100.00%
SealedEnumTypeSpec.kt 100.00%

Modified Files Not Found In Coverage Report:

CreateSealedEnumFromEnumTests.kt
EmptySealedClass.kt
EmptySealedClassTests.kt
EmptySealedInterface.kt
EmptySealedInterfaceTests.kt
EnumForSealedEnumProvider.kt
EnvironmentsSealedEnum.kt
EnvironmentsSealedEnumTests.kt
GenericSealedClass.kt
JavaBaseClasses.kt
NestedObjectsWithSameName.kt
NestedObjectsWithSameNameTests.kt
OneObjectSealedClass.kt
OneObjectSealedClassTests.kt
OneObjectSealedInterface.kt
OneObjectSealedInterfaceTests.kt
OutsideSealedClass.kt
PrivateInterfaceSealedClass.kt
PrivateInterfaceSealedClassTests.kt
ProtectedInterfaceSealedClass.kt
ProtectedInterfaceSealedClassTests.kt
ProtectedInterfaceSealedClassWithDifferentPackageBaseClass.kt
ProtectedInterfaceSealedClassWithDifferentPackageBaseClassTests.kt
SealedClassHierarchy.kt
SealedEnumWithAbstractBaseClasses.kt
SealedEnumWithInterfaces.kt
SealedInterfaceHierarchy.kt
SplitAcrossFilesSealedClass.kt
TraversalOrder.kt
TwoObjectSealedClass.kt
TwoObjectSealedClassTests.kt
TwoObjectSealedInterface.kt
TwoObjectSealedInterfaceTests.kt
VisibilitySealedClass.kt
VisibilitySealedClassTests.kt
runtime.api

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@alexvanyo
Copy link
Collaborator Author

Thanks @brian-livefront ! Merging this after the 0.6.0 release to have a Kotlin 1.8 update without any breaking changes included.

@alexvanyo alexvanyo merged commit 12257ab into main Apr 7, 2023
@alexvanyo alexvanyo deleted the av/class-to-kclass branch April 7, 2023 19:48
@alexvanyo alexvanyo mentioned this pull request Apr 7, 2023
10 tasks
@alexvanyo alexvanyo mentioned this pull request Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert Class to KClass in EnumForSealedEnumProvider

2 participants