Skip to content

Use setWith with appropriate customizer to always create nested objects instead of arrays #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gusbicalho wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use setWith with appropriate customizer to always create nested objects instead of arrays #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/core/src/reducers/core.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,13 @@
*/

import cloneDeep from 'lodash/cloneDeep';
import setFp from 'lodash/fp/set';
import setWithFp from 'lodash/fp/setWith';
import unsetFp from 'lodash/fp/unset';
import get from 'lodash/get';
import filter from 'lodash/filter';
import isEqual from 'lodash/isEqual';
import isFunction from 'lodash/isFunction';
import isObject from 'lodash/isObject';
import type Ajv from 'ajv';
import type { ErrorObject, ValidateFunction } from 'ajv';
import {
Expand Down Expand Up @@ -273,7 +274,8 @@ export const coreReducer: Reducer<JsonFormsCore, CoreActions> = (
const newData = action.updater(cloneDeep(oldData));
let newState: any;
if (newData !== undefined) {
newState = setFp(
newState = setWithFp(
(v: any) => (isObject(v) ? v : {}),
action.path,
newData,
state.data === undefined ? {} : state.data
Expand Down