This repository was archived by the owner on Sep 16, 2021. It is now read-only.
Fix implementation of hd derivation to be bip32 compliant #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braydonf
force-pushed
the
litecoin-bip32
branch
from
fef7a2f to
db466f7
Compare
Author
|
I think there is a non related test that needs updating at |
|
Haven't looked through this in depth, but are you using the BIP32 serialisation values defined in Bitcoin Core, or that defined in bip32.org? Litecoin Core does not use the BIP32 serialisation value defined in bip32.org. |
Author
|
Not related to the serialization values: https://github.com/litecoin-project/litecore-lib/blob/master/lib/networks.js#L135-L136 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See bitpay#97 for more details.