Open
Conversation
ivannizh
approved these changes
Apr 1, 2025
ivannizh
left a comment
ivannizh
left a comment
There was a problem hiding this comment.
Василиса, привет!
Отлично получилось поработать со структурами и интерфейсами, работа принята!
| ... | ||
| func (ds *DaySteps) Parse(datastring string) (err error) { | ||
| parts := strings.Split(datastring, ",") | ||
| if len(parts) == 2 { |
There was a problem hiding this comment.
Большой блок IF и маленький else - плохо!
Можно просто инвертировать условие, чтобы был маленький IF с выходом из функции
| if len(parts) == 2 { | ||
| num, err := strconv.Atoi(parts[0]) | ||
| if err != nil { | ||
| return errors.New("ошибка конвертации строки в int") |
There was a problem hiding this comment.
- Теряешь сообщение об ошибки
- Ошибку лучше писать на английском
Suggested change
| return errors.New("ошибка конвертации строки в int") | |
| return fmt.Errorf("conversion error: %w", err) |
| // создайте метод ActionInfo() | ||
| ... | ||
| func (ds DaySteps) ActionInfo() (string, error) { | ||
| if ds.Duration <= 0 { |
There was a problem hiding this comment.
Тут нигде не используется в расчетах, так что можно опустить
| dist := spentenergy.Distance(ds.Steps) | ||
| cal, err := spentenergy.WalkingSpentCalories(ds.Steps, ds.Weight, ds.Height, ds.Duration) | ||
| if err != nil { | ||
| return "", errors.New("ошибка подсчета каллорий") |
There was a problem hiding this comment.
Suggested change
| return "", errors.New("ошибка подсчета каллорий") | |
| return "", fmt.Errorf("error in WalkingSpentCalories: %w", err) |
| var dur time.Duration | ||
| var act string | ||
| slice := strings.Split(datastring, ",") | ||
| if len(slice) == 3 { |
There was a problem hiding this comment.
Аналогично нужно инвертировать условие
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.