Update Queryhelper.cfc, resolves odd column names#7
Open
dheighton wants to merge 1 commit intoliquifusion:masterfrom
Open
Update Queryhelper.cfc, resolves odd column names#7dheighton wants to merge 1 commit intoliquifusion:masterfrom
dheighton wants to merge 1 commit intoliquifusion:masterfrom
Conversation
Change the column name creation in queryhelper.cfc to fix an issue with specifically the aging report, but could show up elsewhere if illegal characters were in the column name. Code also appends custom_ in front of custom fields, and appends just an _ if the field starts with a numeric character, which is illegal only as the starting character in Coldfusion Query objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the column name creation in queryhelper.cfc to fix an issue with specifically the aging report, but could show up elsewhere if illegal characters were in the column name. Code also appends custom_ in front of custom fields, and appends just an _ if the field starts with a numeric character, which is illegal only as the starting character in Coldfusion Query objects.
Fixes issue #6
This does not address the same bug happening in the Coldfusion implementation of XMLRPC, which issue #3 deals with.