Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
latte-umbrella/src/test/examples/URLConnectionSetPropertyMultipleShort.java:32
- Consider renaming 'requestMethode' to 'requestMethod' for consistent spelling.
public URLConnection openConnection(@Borrowed URL url, boolean in, boolean out, String requestMethode) throws IOException {
Comment on lines
+98
to
+99
| assert(false); | ||
| } |
There was a problem hiding this comment.
Consider using fail() from JUnit instead of assert(false), as the built-in assert may be disabled in production runs.
Suggested change
| assert(false); | |
| } | |
| fail(); |
Comment on lines
+31
to
+35
| public URLConnection openConnection(@Borrowed URL url, boolean in, boolean out, String requestMethode) throws IOException{ | ||
| URLConnection con = url.openConnection(); | ||
| con.setDoInput(in); | ||
| con.setDoOutput (out); | ||
| con.setRequestMethod(requestMethode); |
There was a problem hiding this comment.
Consider renaming 'requestMethode' to 'requestMethod' for consistent spelling.
Suggested change
| public URLConnection openConnection(@Borrowed URL url, boolean in, boolean out, String requestMethode) throws IOException{ | |
| URLConnection con = url.openConnection(); | |
| con.setDoInput(in); | |
| con.setDoOutput (out); | |
| con.setRequestMethod(requestMethode); | |
| public URLConnection openConnection(@Borrowed URL url, boolean in, boolean out, String requestMethod) throws IOException{ | |
| URLConnection con = url.openConnection(); | |
| con.setDoInput(in); | |
| con.setDoOutput (out); | |
| con.setRequestMethod(requestMethod); |
Comment on lines
+50
to
+54
| ### Prerequisites | ||
|
|
||
| - Java 11 or higher | ||
| - Maven | ||
|
|
There was a problem hiding this comment.
[nitpick] Duplicate 'Prerequisites' header detected; consider removing the redundant section for clarity.
Suggested change
| ### Prerequisites | |
| - Java 11 or higher | |
| - Maven |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated readme and testes template for PRs
Add examples
Type of change