Skip to content

Conversation

@liocle
Copy link
Owner

@liocle liocle commented Jul 13, 2025

This PR refactors the GitHub Actions workflow and Makefile to:

  1. Decouple Lint & Test Jobs

    • Lint failures will no longer block the test suite from running
    • Tests always execute, even if formatting checks fail
  2. Use Repository Variables for DB Config

    • Switch from hard-coded env/secrets to ${{ vars.* }} for ports and versions
  3. Enable Coverage Reports Locally

    • Add pytest_local Makefile target that runs:
      • --cov=app
      • --cov-report=term-missing
      • --cov-report=xml
      • --cov-report=html
  4. General Cleanup

    • Fix healthcheck syntax in CI
    • Remove stray blank lines in routes_misc.py
    • Add PYTHONPATH=./app so CI can find the config module

How to test locally

make pytest_local
open htmlcov/index.html 

liocle and others added 7 commits July 12, 2025 16:41
- move secrets into job-level env block
- reference ${ env.POSTGRES_PORT } in service ports
– Extend pytest_local target to invoke pytest with --cov flags so it produces terminal, XML, and HTML coverage outputs.
– Saves reports under htmlcov/ and coverage.xml
- Remove `needs: lint` so “Python Tests & Coverage” runs regardless of lint outcome
- Ensure test failures continue to block merges even if lint errors occur
- Keep lint feedback without preventing the test suite from executing  Ask ChatGPT
@liocle liocle merged commit e24b713 into main Jul 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants