Skip to content

Hard-code IPv4 in the FPing probe #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DeflateAwning wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Hard-code IPv4 in the FPing probe #159

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1bb894
Hard-code IPv4 in the FPing probe
DeflateAwning Oct 20, 2023
9e6ffc7
Create separate FPing4 hard-coded probe
DeflateAwning Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions root/defaults/smoke-conf/Probes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
+ FPing
binary = /usr/sbin/fping

+ FPing4
Copy link
Member

@drizuid drizuid Feb 24, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK i found why this PR build fails, the probes still depend on a perl package; FPing4 doesn't exist therefore it's causing the build to fail. the proper solution is what we discussed a while back, leave FPing6 with protocol=6 as it already is, specify protocol=4 for FPing.

Creating the fping4 causes the build to fail with

require Smokeping::probes::FPing4 failed: Can't locate Smokeping/probes/FPing4.pm in @INC (you may need to install the Smokeping::probes::FPing4 module) (@INC entries checked: .. /usr/share/smokeping /usr/local/lib/perl5/site_perl /usr/local/share/perl5/site_perl /usr/lib/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib/perl5/core_perl /usr/share/perl5/core_perl) at (eval 93) line 1, <$fh> line 6.

because, as mentioned, FPing4 doesnt exist in perl.

Copy link
Contributor Author

@DeflateAwning DeflateAwning Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any advice on what to do with this then?

binary = /usr/sbin/fping
protocol = 4

+ FPing6
binary = /usr/sbin/fping
protocol = 6
Expand Down