Skip to content

Conversation

@flexiondotorg
Copy link
Contributor

  • Add tipHighCrestFactor to detect excessive peak-to-average (crest) ratios
    and prefer SpeechProfile.CrestFactor when available (fires > 20 dB).
  • Update tip suppression rules:
    • Do not suppress quiet tips when high_crest_factor also fired (compound case).
    • Suppress quiet tips when too_far_from_mic fires (root-cause).
  • Clamp suggested gain increases to available peak headroom and annotate messages when clamping occurs so users understand the headroom constraint.
  • Change quiet/too-quiet messages to recommend pop filter/handling checks
    when peaks are already near the ceiling (peak-to-average problem).
  • Make clipping/near-clipping messages contextual:
    • Compute and show suggested reduction in dB where appropriate.
    • Emit a distinct message when clipping occurs but recording is otherwise
      very quiet (plosives/handling noise).
  • Update and expand recording_tips_test.go to cover:
    • crest-factor rule and speech-profile override behaviour
    • gain clamping, clamped-message variants, and contextual clipping cases

- Add tipHighCrestFactor to detect excessive peak-to-average (crest)
ratios
  and prefer SpeechProfile.CrestFactor when available (fires > 20 dB).
- Update tip suppression rules:
  - Do not suppress quiet tips when high_crest_factor also fired
(compound case).
  - Suppress quiet tips when too_far_from_mic fires (root-cause).
- Clamp suggested gain increases to available peak headroom and annotate
  messages when clamping occurs so users understand the headroom
constraint.
- Change quiet/too-quiet messages to recommend pop filter/handling
checks
  when peaks are already near the ceiling (peak-to-average problem).
- Make clipping/near-clipping messages contextual:
  - Compute and show suggested reduction in dB where appropriate.
  - Emit a distinct message when clipping occurs but recording is
otherwise
    very quiet (plosives/handling noise).
- Update and expand recording_tips_test.go to cover:
  - crest-factor rule and speech-profile override behaviour
  - gain clamping, clamped-message variants, and contextual clipping
cases

Signed-off-by: Martin Wimpress <martin@wimpress.org>
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@flexiondotorg flexiondotorg merged commit 4513878 into main Feb 6, 2026
5 checks passed
@flexiondotorg flexiondotorg deleted the accurate branch February 6, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant