feat(logging): normalise final spectral metrics for gain comparison #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Propagate NormalisationResult into report generation and pass to noise-floor and speech-region tables - Compute effective normalisation gain (dB) and enable gain-normalise mode when available - Compensate final spectral metrics (mean, variance, flux, slope) by dividing out applied gain using scaling power per-metric - Add normaliseForGain helper to internal/logging/table.go - Add tests for normaliseForGain and for table output: - verify † markers and footnote appear when normalisation present - verify no markers/footnote when normalisation absent Impact: final spectral metrics in reports are now gain-normalised for reliable cross-stage comparisons; reports include a † marker and a footnote showing the effective gain when applied. Signed-off-by: Martin Wimpress <martin@wimpress.org>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: final spectral metrics in reports are now gain-normalised for reliable cross-stage comparisons; reports include a † marker and a footnote showing the effective gain when applied.