feat(logging): make recording tips speech-aware and refine rules #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use SpeechProfile.RMSLevel when available for level_too_quiet and level_quiet checks; fall back to InputI-based LUFS thresholds when no speech profile exists. - Set speech gain target to -24 dBFS (speech RMS) and keep -18 LUFS for InputI fallback; compute and surface suggested gain dynamically. - Expand mutual-exclusion logic so clipping (level_clipping) and near-clipping (level_near_clipping) suppress quiet tips to avoid confusing recommendations. - Simplify dynamic-range tip to trigger only when InputLRA > 18 LU. - Update and extend tests (internal/logging/recording_tips_test.go) to cover speech-aware paths and mutual-exclusion scenarios. Signed-off-by: Martin Wimpress <martin@wimpress.org>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checks; fall back to InputI-based LUFS thresholds when no speech profile exists.
fallback; compute and surface suggested gain dynamically.
(level_near_clipping) suppress quiet tips to avoid confusing recommendations.
speech-aware paths and mutual-exclusion scenarios.