Skip to content

Conversation

@wineee
Copy link
Member

@wineee wineee commented Jan 5, 2026

This reverts commit 779832f.

Summary by Sourcery

Enhancements:

  • Wrap TreelandUserConfig in a std::unique_ptr within Helper and adjust initialization and accessors accordingly.

@deepin-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wineee

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 5, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Reverts the previous temporary disabling of the TreelandUserConfig smart pointer by restoring m_config as a std::unique_ptr and updating all call sites to use smart-pointer semantics again.

Class diagram for Helper with TreelandUserConfig unique_ptr

classDiagram
    class Helper {
        +Helper(QObject parent)
        +static Helper instance()
        +TreelandUserConfig config()
        +TreelandConfig globalConfig()
        -static Helper m_instance
        -std_unique_ptr_TreelandUserConfig m_config
        -std_unique_ptr_TreelandConfig m_globalConfig
        -Treeland_Treeland m_treeland
        -FpsDisplayManager m_fpsManager
        -void init(Treeland_Treeland treeland)
    }

    class TreelandUserConfig {
        +static TreelandUserConfig createByName(QString name, QString service, QString path)
    }

    class TreelandConfig {
        +static TreelandConfig create(QString service, QString path)
    }

    class std_unique_ptr_TreelandUserConfig {
        +TreelandUserConfig get()
        +void reset(TreelandUserConfig ptr)
        -TreelandUserConfig pointer
    }

    class std_unique_ptr_TreelandConfig {
        +TreelandConfig get()
        +void reset(TreelandConfig ptr)
        -TreelandConfig pointer
    }

    Helper --> TreelandUserConfig : uses
    Helper --> TreelandConfig : uses
    Helper *-- std_unique_ptr_TreelandUserConfig : owns m_config
    Helper *-- std_unique_ptr_TreelandConfig : owns m_globalConfig
    std_unique_ptr_TreelandUserConfig --> TreelandUserConfig : manages
    std_unique_ptr_TreelandConfig --> TreelandConfig : manages
Loading

File-Level Changes

Change Details Files
Restore m_config as a std::unique_ptr-managed TreelandUserConfig and fix its usage sites.
  • Change m_config member from raw TreelandUserConfig* with nullptr initialization to std::unique_ptr.
  • Wrap TreelandUserConfig::createByName calls with m_config.reset(...) to manage ownership via the smart pointer.
  • Adjust Helper::config() to return m_config.get() instead of the smart pointer object.
src/seat/helper.cpp
src/seat/helper.h

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants