-
Notifications
You must be signed in to change notification settings - Fork 34
Revert "chore: temporary disable TreelandUserConfig smart pointer" #678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This reverts commit 779832f.
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wineee The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReverts the previous temporary disabling of the TreelandUserConfig smart pointer by restoring m_config as a std::unique_ptr and updating all call sites to use smart-pointer semantics again. Class diagram for Helper with TreelandUserConfig unique_ptrclassDiagram
class Helper {
+Helper(QObject parent)
+static Helper instance()
+TreelandUserConfig config()
+TreelandConfig globalConfig()
-static Helper m_instance
-std_unique_ptr_TreelandUserConfig m_config
-std_unique_ptr_TreelandConfig m_globalConfig
-Treeland_Treeland m_treeland
-FpsDisplayManager m_fpsManager
-void init(Treeland_Treeland treeland)
}
class TreelandUserConfig {
+static TreelandUserConfig createByName(QString name, QString service, QString path)
}
class TreelandConfig {
+static TreelandConfig create(QString service, QString path)
}
class std_unique_ptr_TreelandUserConfig {
+TreelandUserConfig get()
+void reset(TreelandUserConfig ptr)
-TreelandUserConfig pointer
}
class std_unique_ptr_TreelandConfig {
+TreelandConfig get()
+void reset(TreelandConfig ptr)
-TreelandConfig pointer
}
Helper --> TreelandUserConfig : uses
Helper --> TreelandConfig : uses
Helper *-- std_unique_ptr_TreelandUserConfig : owns m_config
Helper *-- std_unique_ptr_TreelandConfig : owns m_globalConfig
std_unique_ptr_TreelandUserConfig --> TreelandUserConfig : manages
std_unique_ptr_TreelandConfig --> TreelandConfig : manages
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This reverts commit 779832f.
Summary by Sourcery
Enhancements: