feat: add fuzzy field in statistics info. #6

yyc12345 · 2025-05-12T08:03:05Z

add fuzzy field in MessageStats to handle PO file fuzzy entries properly.
add Rust document for MessageStats and its fields to tell the meaning of these fields for developer.
update MessageStats creation function for Ts and Po respectively.
add 3 functions in MessageStats to compute values showen in statistics.rs.
- finished field are shown as "translated"
- obsolute and vanished fields are shown as "vanished".
- unfinished and fuzzy fields are shown as "unfinished".
update table columns and showcase in sub command statistics for hereinabove changes.

Summary by Sourcery

Introduce support for fuzzy translation entries in statistics, update reporting logic and documentation, and adjust tests accordingly.

New Features:

Add 'fuzzy' field to MessageStats to track fuzzy entries in PO files.

Enhancements:

Update statistics computation and display to include fuzzy entries as unfinished and combine obsolete/vanished fields for reporting.
Add developer-facing documentation for MessageStats and its fields.

Tests:

Update and add tests to cover fuzzy entry handling in statistics.

deepin-ci-robot · 2025-05-12T08:03:18Z

Hi @yyc12345. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sourcery-ai · 2025-05-12T08:05:49Z

Reviewer's Guide

This pull request adds a 'fuzzy' field to MessageStats to accurately track fuzzy entries in PO files, updates statistics computation and table output to reflect the new and reclassified fields, and enhances documentation for MessageStats and its fields. The implementation involves changes to the MessageStats struct, its creation logic for TS and PO files, new methods for statistics computation, and updates to the statistics display in the CLI output.

File-Level Changes

Change	Details	Files
Add 'fuzzy' field to MessageStats and update related logic.	Introduce 'fuzzy' field in MessageStats struct. Update MessageStats::new and Default to initialize 'fuzzy'. Update AddAssign implementation to include 'fuzzy'. Expand Rust documentation for all MessageStats fields.	`src/i18n_file/common.rs`
Update statistics computation and classification for TS and PO files.	Refactor Ts::get_message_stats to use new MessageStats::new and field assignments. Update Po::get_message_stats to increment 'fuzzy' for fuzzy entries and adjust unfinished count. Update related test cases to account for 'fuzzy' field.	`src/i18n_file/linguist.rs` `src/i18n_file/gettext.rs`
Add methods to MessageStats for statistics display and update CLI output.	Add shown_translated, shown_unfinished, and shown_obsolete methods to MessageStats. Update completeness_percentage to use new methods. Update statistics table output in subcmd/statistics.rs to reflect new and reclassified fields.	`src/i18n_file/common.rs` `src/subcmd/statistics.rs`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

We encountered an error and are unable to review this PR. We have been notified and are working to fix it.

You can try again by commenting this pull request with @sourcery-ai review, or contact us for help.

- add fuzzy field in MessageStats to handle PO file fuzzy entries properly. - add Rust document for MessageStats and its fields to tell the meaning of these fields for developer. - update MessageStats creation function for Ts and Po respectively. - add 3 functions in MessageStats to compute values showen in `statistics.rs`. * finished field are shown as "translated" * obsolete and vanished fields are shown as "vanished". * unfinished and fuzzy fields are shown as "unfinished". - update table columns and showcase in sub command statistics for hereinabove changes.

BLumia · 2025-05-12T08:19:21Z

@sourcery-ai review

deepin-ci-robot · 2025-05-12T08:20:28Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, yyc12345

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sourcery-ai

Hey @yyc12345 - I've reviewed your changes - here's some feedback:

Consider renaming the 'fuzzy' field to clarify its purpose, as it may not be immediately clear to all users that it refers specifically to PO file fuzzy entries.
Ensure that the updated statistics table output remains consistent with any external tools or scripts that may parse its columns, as the column order and names have changed.

Here's what I looked at during the review

🟡 General issues: 1 issue found
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

sourcery-ai · 2025-05-12T08:27:32Z

src/i18n_file/common.rs

 }

 impl MessageStats {
+    pub fn new() -> Self {


suggestion: Redundant Default and new constructors for MessageStats.

Since Default and new both zero-initialize all fields, use just one to avoid confusion and reduce maintenance.

deepin-ci-robot added the needs-ok-to-test label May 12, 2025

yyc12345 force-pushed the patch branch from 1c82e82 to 91023e8 Compare May 12, 2025 08:09

sourcery-ai bot reviewed May 12, 2025

View reviewed changes

yyc12345 force-pushed the patch branch from 91023e8 to b24d03c Compare May 12, 2025 08:17

BLumia approved these changes May 12, 2025

View reviewed changes

BLumia merged commit dec499a into linuxdeepin:master May 12, 2025
4 checks passed

sourcery-ai bot reviewed May 12, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add fuzzy field in statistics info. #6

feat: add fuzzy field in statistics info. #6

Uh oh!

yyc12345 commented May 12, 2025 •

edited by sourcery-ai bot

Loading

Uh oh!

deepin-ci-robot commented May 12, 2025

Uh oh!

sourcery-ai bot commented May 12, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Uh oh!

BLumia commented May 12, 2025

Uh oh!

deepin-ci-robot commented May 12, 2025

Uh oh!

Uh oh!

sourcery-ai bot left a comment

Uh oh!

sourcery-ai bot May 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: add fuzzy field in statistics info. #6

feat: add fuzzy field in statistics info. #6

Uh oh!

Conversation

yyc12345 commented May 12, 2025 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Sourcery

Uh oh!

deepin-ci-robot commented May 12, 2025

Uh oh!

sourcery-ai bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

BLumia commented May 12, 2025

Uh oh!

deepin-ci-robot commented May 12, 2025

Uh oh!

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot May 12, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yyc12345 commented May 12, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented May 12, 2025 •

edited

Loading