Skip to content

chore: update gtk theme#167

Merged
mhduiy merged 1 commit intolinuxdeepin:masterfrom
mhduiy:update
Mar 7, 2025
Merged

chore: update gtk theme#167
mhduiy merged 1 commit intolinuxdeepin:masterfrom
mhduiy:update

Conversation

@mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Mar 7, 2025

Merge designer requirements

pms: TASK-368711

Merge designer requirements

pms: TASK-368711
@deepin-ci-robot
Copy link

deepin pr auto review

根据提供的代码差异,主要涉及的是对图片文件和CSS样式的修改。以下是对这些更改的审查意见:

图片文件

  • 图片文件的更改通常不会影响代码的语法和逻辑,但需要确保这些更改是经过设计团队审核的,并且与整体设计风格保持一致。
  • 如果这些图片文件是用于UI组件的,建议检查图片的分辨率和大小,确保它们不会对性能产生负面影响。

CSS样式

  • deepin-dark/gtk-2.0/gtkrc文件中,insensitive_fg_color的颜色值从#555555更改为#a9acb2,这可能会影响用户界面的可读性。建议确认这一更改是否符合设计规范。
  • deepin-dark/gtk-3.0/gtk.css文件中,border-color属性从rgba(0, 0, 0, 0)更改为none,这可能会影响组件的边框显示。需要确认这一更改是否正确,并且不会导致布局问题。
  • deepin-dark/gtk-3.0/gtk.css文件中,headerbar.default-decoration button.titlebuttonpaddingmin-widthmin-heightmargin属性都进行了修改。这些更改可能会影响按钮的布局和可用性,需要确保这些更改不会破坏现有的布局和用户体验。
  • deepin-dark/gtk-3.0/gtk.css文件中,headerbar box.rightmargin-right属性从-3px更改为-7px,这可能会影响右对齐的组件。需要确认这一更改是否符合设计规范。

其他

  • deepin/index.theme文件的权限从100644更改为100755,这可能会影响文件的执行权限。需要确认这一更改是否必要,并且不会对系统安全造成风险。

总的来说,这些更改看起来是针对UI/UX的调整,需要确保这些更改不会破坏现有的功能,并且与整体设计风格保持一致。如果这些更改是由设计团队提出的,建议与设计团队进行进一步的沟通和确认。

@mhduiy mhduiy requested a review from 18202781743 March 7, 2025 02:35
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy mhduiy merged commit ad50fb4 into linuxdeepin:master Mar 7, 2025
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants