Skip to content

chore: update version to 6.5.21#358

Merged
lzwind merged 1 commit intolinuxdeepin:develop/snipefrom
pengfeixx:changelog
Jan 22, 2026
Merged

chore: update version to 6.5.21#358
lzwind merged 1 commit intolinuxdeepin:develop/snipefrom
pengfeixx:changelog

Conversation

@pengfeixx
Copy link
Contributor

@pengfeixx pengfeixx commented Jan 22, 2026

update version to 6.5.21

Log: update version to 6.5.21

Summary by Sourcery

Build:

  • Update Debian packaging changelog to reflect version 6.5.21.

update version to 6.5.21

Log: update version to 6.5.21
@github-actions
Copy link

TAG Bot

TAG: 6.5.21
EXISTED: no
DISTRIBUTION: unstable

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 22, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Bumps the package version to 6.5.21 in the Debian changelog metadata.

File-Level Changes

Change Details Files
Update Debian package metadata to version 6.5.21.
  • Adjust the version string in the latest debian/changelog entry to 6.5.21.
  • Ensure the associated log message in the changelog reflects the 6.5.21 version bump.
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

deepin pr auto review

这段 debian/changelog 的 diff 输出记录了 deepin-compressor 软件包从 6.5.20 版本升级到 6.5.21 版本的变更信息。从格式规范的角度来看,这段 diff 符合 Debian 的 changelog 规范,但在内容逻辑和细节上存在一些可以改进的地方。

以下是针对该 diff 的审查意见,分为格式规范、逻辑内容、代码质量和安全性四个方面:

1. 格式规范

  • 符合 Debian 标准:整体格式遵循了 dpkg-parsechangelog 的标准,包括包名、版本号、发行版、紧急程度、维护者信息和日期。
  • 缩进正确:变更条目使用了正确的缩进(两个空格加一个空行)。
  • 改进建议:日期异常
    • 问题:日期显示为 Thu, 22 Jan 2026
    • 意见:除非这是为了测试未来版本的时间旅行功能,否则这是一个明显的笔误。年份 2026 应该修正为当前年份(例如 20242025)。错误的年份可能会影响自动构建工具或版本排序逻辑。

2. 逻辑内容

  • 变更分类:使用了 fixrefactor 前缀,这有助于快速理解变更的性质,做法很好。
  • 条目清晰度
    • fix: Fix Chinese password compression failure:描述清晰,指明了特定场景(中文密码)和问题。
    • fix: Fix issue where adding system files shows no prompt:描述清晰。
    • refactor: Remove pzip plugin and update CMake configuration:重构描述准确,指出了移除的组件和构建系统的变更。
    • fix: Fix incorrect names when extracting encrypted folders:描述清晰。
  • 改进建议:措辞一致性
    • 大部分条目以动词开头,但风格略显混杂。
    • 建议:统一使用祈使句或过去分词形式。在 Debian changelog 中,通常使用祈使句(如 "Fix...", "Add...", "Remove...")是比较标准的做法,目前的写法基本符合,但可以更精简。
    • 例如:fix: Fix Chinese password compression failure 可以改为 fix: Fix failure of compression with Chinese password 或保持原样。
    • fix: Fix the issue where the input box cannot lose focus 中的 "the issue where" 略显冗余,建议精简为 fix: Fix input box unable to lose focus

3. 代码质量

虽然 changelog 本身不是代码,但它反映了代码库的变更:

  • 重构影响refactor: Remove pzip plugin 是一个较大的变更。建议确认:
    • 是否有替代方案处理该插件支持的格式?
    • CMake 配置更新后,是否在所有支持的发行版上测试通过?
  • 修复覆盖面:本次提交包含了多个 UI 交互(输入框焦点、右键菜单翻译)和底层功能(压缩格式、加密文件夹)的修复。建议确认这些修复是否经过了充分的回归测试,特别是涉及中文密码和加密文件的处理,这些通常是容易出错的边界情况。

4. 安全性

  • 潜在风险
    • fix: Fix Chinese password compression failure:修复了中文密码的问题。需要确认之前的失败是否导致了数据以不安全的方式处理(例如,密码验证失败后是否错误地解密了数据?或者是否在日志中泄露了信息?)。
    • fix: Fix incorrect names when extracting encrypted folders:文件名错误在解压时可能导致路径遍历攻击(如果文件名包含 ../)或文件覆盖攻击。需要确认修复不仅仅是让文件名显示正确,还要确保解压路径的安全性验证逻辑是正确的。
  • 改进建议
    • 如果上述安全问题在旧版本中存在严重隐患,建议在 changelog 中增加一个 security 标签,或者在发布说明中重点强调。

总结与修改建议

这段 diff 整体格式良好,但存在明显的日期错误。建议修改如下:

diff --git a/debian/changelog b/debian/changelog
index 8a57f031..d047c41a 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,15 @@
+deepin-compressor (6.5.21) unstable; urgency=medium
+
+  * fix: Fix compression failure with Chinese passwords
+  * fix: Fix missing prompt when adding system files
+  * refactor: Remove pzip plugin and update CMake configuration
+  * fix: Fix incorrect naming when extracting encrypted folders
+  * fix: Fix untranslated Japanese in right-click menu
+  * fix: Fix input box unable to lose focus
+  * fix: Fix unavailability of tar.lzo compression format
+
+ -- xiepengfei <xiepengfei@uniontech.com>  Thu, 22 Jan 2024 19:13:37 +0800
+
 deepin-compressor (6.5.20) unstable; urgency=medium
 
   * fix: Add support for symbolic links in file compression

修改点说明:

  1. 年份修正:将 2026 改为 2024(假设当前时间)。
  2. 措辞优化
    • Fix Chinese password compression failure -> Fix compression failure with Chinese passwords(语法更通顺)。
    • Fix issue where adding system files shows no prompt -> Fix missing prompt when adding system files(更简洁)。
    • Fix the issue where the input box cannot lose focus -> Fix input box unable to lose focus(去除了冗余词汇)。
    • Fix tar.lzo compression format unavailable -> Fix unavailability of tar.lzo compression format(语法更完整)。

@lzwind lzwind merged commit d2eb353 into linuxdeepin:develop/snipe Jan 22, 2026
16 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, pengfeixx

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pengfeixx pengfeixx deleted the changelog branch January 22, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants