Skip to content

chore: Update version to 6.5.20#350

Merged
lzwind merged 1 commit intolinuxdeepin:develop/snipefrom
dengzhongyuan365-dev:pzip-cpp
Jan 16, 2026
Merged

chore: Update version to 6.5.20#350
lzwind merged 1 commit intolinuxdeepin:develop/snipefrom
dengzhongyuan365-dev:pzip-cpp

Conversation

@dengzhongyuan365-dev
Copy link
Contributor

@dengzhongyuan365-dev dengzhongyuan365-dev commented Jan 16, 2026

  • update version to 6.5.20

log: update version to 6.5.20

Summary by Sourcery

Chores:

  • Bump recorded package version in debian/changelog to 6.5.120.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 16, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Bumps the package version in the Debian changelog to 6.5.20 as part of a release chore.

File-Level Changes

Change Details Files
Update Debian packaging metadata to reflect version 6.5.20.
  • Increment the recorded package version in the Debian changelog to 6.5.20.
  • Adjust the associated log entry text in the changelog to reference version 6.5.20.
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

TAG Bot

TAG: 6.5.20
EXISTED: no
DISTRIBUTION: unstable

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

- update version to 6.5.20

log: update version to 6.5.20
@deepin-ci-robot
Copy link

deepin pr auto review

这段 debian/changelog 的 diff 内容总体上是符合 Debian 打包规范的,格式正确,包含了版本号、发行版、紧急程度、变更描述以及维护者信息。

以下是对该 diff 的详细审查和改进建议:

1. 语法逻辑与格式审查

  • 格式规范性

    • 该变更严格遵循了 Debian changelog 文件的格式要求:package (version) distribution(s); urgency=urgency
    • 变更条目使用缩进(通常是两个空格),并以 -- 开头的尾行结束,最后是维护者信息和时间戳。
    • 时间戳格式 Fri, 16 Jan 2026 15:23:54 +0800 符合 RFC 5322 标准。
  • 版本号

    • 版本从 6.5.19 升级到 6.5.20,符合版本号递增逻辑。
  • 时间戳异常

    • 问题:时间戳显示为 2026 年。除非这是为了未来的特定版本预留,否则这很可能是一个笔误。
    • 建议:请确认年份是否应为 20242025。错误的年份可能会影响自动发布工具的判断或造成混淆。

2. 代码质量审查

  • 变更描述
    • fix: Add support for symbolic links in file compression
    • 优点:使用了 fix: 前缀,清晰地表明了这是一个错误修复或功能补丁。描述简洁明了,准确传达了本次更新的目的(增加了对符号链接压缩的支持)。
    • 建议:虽然目前的描述已经足够清晰,但如果这个修复解决了具体的 Bug(例如 Bugzilla ID 或 Issue 编号),建议在描述中附上引用,格式如 fix (Closes: #12345): ...,这样更有利于追踪。

3. 代码性能与安全审查

  • 性能
    • 作为 changelog 文件,本身不涉及执行代码,因此不直接涉及性能问题。
  • 安全
    • 符号链接的安全性:虽然 changelog 只是记录,但从变更内容来看,增加对符号链接的支持可能引入安全风险。
    • 潜在风险:在压缩工具中处理符号链接时,如果不加限制,可能会遇到“符号链接攻击”或“绝对路径穿越”问题。例如,解压时恶意符号链接可能覆盖系统文件。
    • 建议:请确保对应的代码实现中,对符号链接进行了安全检查(例如:禁止解压到压缩包之外的路径、限制使用绝对路径符号链接等)。

4. 综合改进建议

  1. 修正年份:将 2026 修改为当前年份(如 2024),除非确实是在规划未来的版本。
  2. 增强描述:如果存在相关的 Issue 或 Bug ID,建议添加到描述中,例如:
      * fix: Add support for symbolic links in file compression (Closes: #XXXXX)
    
  3. 安全检查提醒:鉴于 changelog 提到了符号链接支持,请务必在代码审查阶段重点检查符号链接处理的安全性,防止路径穿越漏洞。

修正后的示例(假设年份修正为 2024):

+deepin-compressor (6.5.20) unstable; urgency=medium
+
+  * fix: Add support for symbolic links in file compression
+
+ -- dengzhongyuan <dengzhongyuan@uniontech.com>  Fri, 16 Jan 2024 15:23:54 +0800
+
 deepin-compressor (6.5.19) unstable; urgency=medium

@dengzhongyuan365-dev dengzhongyuan365-dev changed the title chore: Update version to 6.5.120 chore: Update version to 6.5.20 Jan 16, 2026
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dengzhongyuan365-dev, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind lzwind merged commit e7b9c40 into linuxdeepin:develop/snipe Jan 16, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants