Closed
Conversation
Reviewer's GuideThis PR standardizes translation files by updating TS headers, adjusting source location offsets, refreshing and correcting translation strings across languages, flagging unfinished entries, and synchronizing desktop entry metadata. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @JWWTSL - I've reviewed your changes - here's some feedback:
- The newly added de_DE.ts file is entirely marked as unfinished; please either provide the German translations or omit this file from the PR to avoid shipping empty entries.
- Many
<translation>entries across languages are still flagged astype="unfinished"; please ensure all strings are fully localized or remove theunfinishedattribute so untranslated placeholders aren’t displayed in the UI.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The newly added de_DE.ts file is entirely marked as unfinished; please either provide the German translations or omit this file from the PR to avoid shipping empty entries.
- Many `<translation>` entries across languages are still flagged as `type="unfinished"`; please ensure all strings are fully localized or remove the `unfinished` attribute so untranslated placeholders aren’t displayed in the UI.
## Individual Comments
### Comment 1
<location> `src/translations/deepin-boot-maker_fil.ts:55` </location>
<code_context>
<location filename="../app/view/isoselectview.cpp" line="114"/>
<source>Drag an ISO image file here</source>
- <translation>I-drag ang ISO image file dito</translation>
+ <translation>I-click-dito ang file na ISO mo</translation>
</message>
<message>
</code_context>
<issue_to_address>
Colloquial phrasing in Filipino translation may reduce clarity.
Consider replacing 'I-click-dito ang file na ISO mo' with 'I-drag ang ISO image file dito' for greater clarity and accuracy.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
<translation>I-click-dito ang file na ISO mo</translation>
=======
<translation>I-drag ang ISO image file dito</translation>
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| <location filename="../app/view/isoselectview.cpp" line="114"/> | ||
| <source>Drag an ISO image file here</source> | ||
| <translation>I-drag ang ISO image file dito</translation> | ||
| <translation>I-click-dito ang file na ISO mo</translation> |
There was a problem hiding this comment.
suggestion: Colloquial phrasing in Filipino translation may reduce clarity.
Consider replacing 'I-click-dito ang file na ISO mo' with 'I-drag ang ISO image file dito' for greater clarity and accuracy.
Suggested change
| <translation>I-click-dito ang file na ISO mo</translation> | |
| <translation>I-drag ang ISO image file dito</translation> |
Contributor
|
TAG Bot New tag: 6.0.10 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JWWTSL The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
log: update translation.
Please do not send pull requests to the linuxdeepin/*
see https://github.com/linuxdeepin/developer-center/wiki/Contribution-Guidelines-for-Developers
Thanks!
Summary by Sourcery
Update and expand translation files for Deepin Boot Maker to improve localization quality and add support for additional languages.
New Features:
Enhancements: