Skip to content

chore: Comment out tests subdirectory in src.pro - Commented out the SUBDIRS entry for tests in src.pro to exclude it from the build process. - Updated security compilation flags in tests.pro to use -fPIE instead of -fPIC for better compatibility. Log: Adjust project structure and enhance security compilation settings.#88

Merged
lzwind merged 2 commits intolinuxdeepin:masterfrom
dengzhongyuan365-dev:master
Jun 19, 2025

Conversation

@dengzhongyuan365-dev
Copy link
Contributor

@dengzhongyuan365-dev dengzhongyuan365-dev commented Jun 19, 2025

chore: Comment out tests subdirectory in src.pro

  • Commented out the SUBDIRS entry for tests in src.pro to exclude it from the build process.
  • Updated security compilation flags in tests.pro to use -fPIE instead of -fPIC for better compatibility.

Log: Adjust project structure and enhance security compilation settings.

Summary by Sourcery

Exclude the tests subdirectory from the main build and tighten security compilation settings for test targets

Enhancements:

  • Replace -fPIC with -fPIE in tests.pro CFLAGS and CXXFLAGS to enable position-independent executables

Build:

  • Comment out the SUBDIRS entry for tests in src.pro to prevent tests from being built

- Commented out the SUBDIRS entry for tests in src.pro to exclude it from the build process.
- Updated security compilation flags in tests.pro to use -fPIE instead of -fPIC for better compatibility.

Log: Adjust project structure and enhance security compilation settings.
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • src.pro文件中,注释掉了SUBDIRS += tests,这可能会影响测试的执行。需要确认这是有意为之,并且测试已经迁移或不再需要。
  • tests.pro文件中,-fno-access-control标志被移除,这可能会影响代码的安全性。需要确认这是否是有意为之,并且是否有替代的安全措施。

是否建议立即修改:

  • 是,需要确认注释掉测试目录的原因,并确保移除-fno-access-control标志不会影响代码的安全性。如果这些更改是有意为之,应该添加相应的注释说明原因。

@github-actions
Copy link

TAG Bot

TAG: 6.0.6
EXISTED: no
DISTRIBUTION: unstable

@sourcery-ai
Copy link

sourcery-ai bot commented Jun 19, 2025

Reviewer's Guide

This PR adjusts the build configuration by excluding the tests subdirectory from the main project and enhances security flags in the test project by switching from -fPIC to -fPIE.

Flow diagram for build process before and after excluding tests

flowchart TD
    subgraph Before
        A1[src.pro] --> B1[app]
        A1 --> C1[tests]
    end
    subgraph After
        A2[src.pro] --> B2[app]
        %% tests is excluded
    end
Loading

File-Level Changes

Change Details Files
Exclude tests subdirectory from the build
  • Commented out the SUBDIRS entry for tests in the main project file
  • Removed the original un-commented tests entry
src/src.pro
Enhance security compilation flags in test project
  • Replaced -fPIC with -fPIE in QMAKE_CFLAGS
  • Replaced -fPIC with -fPIE in QMAKE_CXXFLAGS
src/tests/tests.pro

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dengzhongyuan365-dev - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dengzhongyuan365-dev, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind lzwind merged commit 53ae36e into linuxdeepin:master Jun 19, 2025
14 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants