chore: Comment out tests subdirectory in src.pro - Commented out the SUBDIRS entry for tests in src.pro to exclude it from the build process. - Updated security compilation flags in tests.pro to use -fPIE instead of -fPIC for better compatibility. Log: Adjust project structure and enhance security compilation settings.#88
Merged
lzwind merged 2 commits intolinuxdeepin:masterfrom Jun 19, 2025
Merged
chore: Comment out tests subdirectory in src.pro - Commented out the SUBDIRS entry for tests in src.pro to exclude it from the build process. - Updated security compilation flags in tests.pro to use -fPIE instead of -fPIC for better compatibility. Log: Adjust project structure and enhance security compilation settings.#88lzwind merged 2 commits intolinuxdeepin:masterfrom
lzwind merged 2 commits intolinuxdeepin:masterfrom
Conversation
- Commented out the SUBDIRS entry for tests in src.pro to exclude it from the build process. - Updated security compilation flags in tests.pro to use -fPIE instead of -fPIC for better compatibility. Log: Adjust project structure and enhance security compilation settings.
deepin pr auto review关键摘要:
是否建议立即修改:
|
|
TAG Bot TAG: 6.0.6 |
Reviewer's GuideThis PR adjusts the build configuration by excluding the tests subdirectory from the main project and enhances security flags in the test project by switching from -fPIC to -fPIE. Flow diagram for build process before and after excluding testsflowchart TD
subgraph Before
A1[src.pro] --> B1[app]
A1 --> C1[tests]
end
subgraph After
A2[src.pro] --> B2[app]
%% tests is excluded
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @dengzhongyuan365-dev - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
lzwind
approved these changes
Jun 19, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dengzhongyuan365-dev, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This was referenced Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: Comment out tests subdirectory in src.pro
Log: Adjust project structure and enhance security compilation settings.
Summary by Sourcery
Exclude the tests subdirectory from the main build and tighten security compilation settings for test targets
Enhancements:
Build: