chore: Update logging#84
Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom May 28, 2025
Merged
Conversation
- Enhanced logging throughout the application for better debugging and tracking of events. - Added .vscode, .cursor, and .specstory files to .gitignore to prevent unnecessary files from being tracked. - Improved initialization and error handling messages in various components for clarity. Log: Update logging
Reviewer's GuideThis PR enriches the application’s observability by systematically adding detailed logging (qDebug, qInfo, qWarning, qCritical) across core installer, service/interface, utility, SevenZip and UI modules, and updates .gitignore to exclude IDE and temp files. Updated Class Diagram for QtBaseInstaller (Enhanced Logging)classDiagram
class QtBaseInstaller {
+QtBaseInstaller(QObject *parent)
+setformat(bool bFormat)
+setPartionName(const QString& strPartionName)
+setImage(const QString& strImage)
+beginInstall()
+checkError()
+stopInstall()
+hasEnoughSpace() bool
+checkISOIntegrity() bool
+umountPartion() bool
+umountDisk() bool
+ejectDisk() bool
+formatUsb() bool
+installBootload() bool
+extractISO() bool
+syncIO() bool
+configSyslinux() bool
+needAddRepo() bool
+modifyBootGrubFile(QString grub_file_name)
}
Updated Class Diagram for BootMakerService (Enhanced Logging)classDiagram
class BootMakerService {
+BootMakerService(QObject *parent)
+~BootMakerService()
+Reboot()
+Start()
+Stop()
+DeviceList() QString
+Install(const QString& image, const QString& device, const QString& partition, bool formatDevice) bool
+CheckFile(const QString& filepath) bool
}
class BootMakerServicePrivate {
+BootMakerServicePrivate(BootMakerService* q)
+checkCaller() bool
+dbusCallerPid() qint64
}
BootMakerService *-- "1" BootMakerServicePrivate : d_ptr
Updated Class Diagram for DeviceMonitor (Enhanced Logging)classDiagram
class DeviceMonitor {
+DeviceMonitor(QObject *parent)
+deviceList() const QList<DeviceInfo>
+getIntersectDevice(const QList<DeviceInfo>& list) QList<DeviceInfo>
+getNorDevice(const QList<DeviceInfo>& calcuList, const QList<DeviceInfo>& compareList) QList<DeviceInfo>
%% Methods' internal logic and constructor lambdas updated with logging
}
Updated Class Diagram for UI (BMWindow & SlideAnimatoin - Enhanced Logging)classDiagram
class BMWindow {
+BMWindow(QWidget *parent)
+slot_ThemeChange()
+~BMWindow()
+closeEvent(QCloseEvent *event)
+slideWidget(DWidget *left, DWidget *right, int iDirection)
%% Methods and constructor lambdas updated with logging
}
class SlideAnimatoin {
+SlideAnimatoin()
+~SlideAnimatoin()
+initAnimation(DWidget* pLeftWidget, DWidget* pRightWidget, int iDirection)
+slot_AnimationGroupFinished()
}
BMWindow ..> SlideAnimatoin : creates
Updated Class Diagram for SevenZip Utilities (Enhanced Logging)classDiagram
class SevenZip {
+SevenZip(const QString& image, const QString& target, QObject* parent)
+setArchiveFile(const QString& archiveFile)
+setOutputDirectory(const QString& outputDir)
+stopProcess()
+extract() bool
+check() bool
+handleFinished()
}
class SevenZipProcessParser {
+SevenZipProcessParser(const QString& file, QProcess* process, QObject* parent)
+run()
}
SevenZip ..> SevenZipProcessParser : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @Kakueeen - I've reviewed your changes and found some issues that need to be addressed.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| qInfo() << "Starting Boot Maker Service"; | ||
|
|
||
| QString PATH = qgetenv("PATH"); | ||
| qDebug() << "Initial PATH:" << PATH; |
There was a problem hiding this comment.
🚨 issue (security): Logging full PATH may expose sensitive environment data
Log only necessary environment variables or mask sensitive information in PATH to avoid exposing private data.
lzwind
approved these changes
May 28, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Kakueeen, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
Contributor
|
This pr force merged! (status: unstable) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log: Update logging