fix(time-range): improve hour input focus behavior

[add-uos]

When entering a single digit hour (3-9), automatically advance focus to the minute input field. This provides a more intuitive time entry experience by recognizing that hours 3-9 are single-digit values in 24-hour format.

log: improve hour input focus behavior
bug: PMS-349815

Summary by Sourcery

Bug Fixes:

• Ensure focus moves from hour to minute input after entering a single-digit hour from 3 to 9, matching 24-hour time semantics.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the hour SpinBox onTextChanged logic so that focus automatically moves to the minute input after a single valid one-digit hour (3–9) or any two-digit hour is entered, improving time entry behavior.

Sequence diagram for updated hour input focus behavior

sequenceDiagram
    actor User
    participant HourSpinBox
    participant MinuteSpinBox

    User->>HourSpinBox: Type first digit
    activate HourSpinBox
    HourSpinBox->>HourSpinBox: onTextChanged(text, focus, typingDigit)
    alt text length is 1 and digit >= 3 and focus and typingDigit
        HourSpinBox->>HourSpinBox: typingDigit = false
        HourSpinBox->>MinuteSpinBox: forceActiveFocus()
        HourSpinBox->>MinuteSpinBox: selectAll()
    else text length is 1 and digit < 3 or not typingDigit or not focus
        HourSpinBox-->>User: Remain in hour input
    end
    deactivate HourSpinBox

    User->>HourSpinBox: Type second digit
    activate HourSpinBox
    HourSpinBox->>HourSpinBox: onTextChanged(text, focus, typingDigit)
    alt text length is 2 and focus and typingDigit
        HourSpinBox->>HourSpinBox: typingDigit = false
        HourSpinBox->>MinuteSpinBox: forceActiveFocus()
        HourSpinBox->>MinuteSpinBox: selectAll()
    else conditions not met
        HourSpinBox-->>User: Remain in hour input
    end
    deactivate HourSpinBox

Loading

File-Level Changes

Change	Details	Files
Refine hour input onTextChanged behavior to move focus earlier for valid single-digit hours in 24-hour format.	Gate all behavior on the hour SpinBox having focus and the user actively typing digits. When the hour text length is 1, parse the first digit and, if it is 3 or greater, move focus to the minute input and select its contents, then reset the typingDigit flag. When the hour text length is 2, always move focus to the minute input and select its contents, then reset the typingDigit flag. Preserve previous behavior of auto-advancing on two-digit entry while adding the new single-digit-hour behavior.	src/dde-control-center/plugin/DccTimeRange.qml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The logic in onTextChanged duplicates the minuteInput.forceActiveFocus() / minuteInput.selectAll() block; consider extracting this into a small helper function or inline lambda to keep the branching readable and DRY.
• When calling parseInt(text, 10) on the single character, it may be safer to guard against non-numeric values (e.g., check with a regex or !isNaN(firstDigit)) so the behavior degrades predictably if the text ever contains unexpected input.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The logic in `onTextChanged` duplicates the `minuteInput.forceActiveFocus()` / `minuteInput.selectAll()` block; consider extracting this into a small helper function or inline lambda to keep the branching readable and DRY.
- When calling `parseInt(text, 10)` on the single character, it may be safer to guard against non-numeric values (e.g., check with a regex or `!isNaN(firstDigit)`) so the behavior degrades predictably if the text ever contains unexpected input.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}