Skip to content

fix(sound): font size of "No output device for sound found" is too large#3002

Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
electricface:swt/fix-bug300469
Feb 3, 2026
Merged

fix(sound): font size of "No output device for sound found" is too large#3002
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
electricface:swt/fix-bug300469

Conversation

@electricface
Copy link
Member

@electricface electricface commented Feb 3, 2026

  • Adjust to t8

fix(sound): “没有找到声音输出设备”字体偏大

  • 调整为 t8

Log:修复 “没有找到声音输出设备”字体偏大问题
Influence: 声音模块字体大小
PMS: BUG-300469

Summary by Sourcery

Bug Fixes:

  • Correct the oversized font used for the "No output device for sound found" message in the sound settings UI.

@sourcery-ai
Copy link

sourcery-ai bot commented Feb 3, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the font style used for the "No output device for sound found" message on the speaker page to use a smaller preset (t8) instead of the previously used larger preset (t4).

File-Level Changes

Change Details Files
Reduce the font size of the "No output device for sound found" message in the speaker page UI by switching to the t8 font style.
  • Update the font binding of the empty-output-device hint text to use DTK.fontManager.t8 instead of DTK.fontManager.t4
src/plugin-sound/qml/SpeakerPage.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

- Adjust to t8

---

fix(sound):  “没有找到声音输出设备”字体偏大

- 调整为 t8

Log:修复 “没有找到声音输出设备”字体偏大问题
Influence: 声音模块字体大小
PMS: BUG-300469
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider extracting the font size (e.g., t8) into a shared style or constant so that similar status/empty-state messages across the sound module and other pages can stay consistent and easier to update in the future.
  • Verify that using DTK.fontManager.t8 for this message stays visually consistent with other 'empty state' or 'no device' messages in the sound settings to avoid introducing a one-off font size here.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider extracting the font size (e.g., t8) into a shared style or constant so that similar status/empty-state messages across the sound module and other pages can stay consistent and easier to update in the future.
- Verify that using DTK.fontManager.t8 for this message stays visually consistent with other 'empty state' or 'no device' messages in the sound settings to avoid introducing a one-off font size here.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@electricface electricface changed the title fix(sound): font size of "No audio output device found" is too large fix(sound): font size of "No output device for sound found" is too large Feb 3, 2026
@deepin-ci-robot
Copy link

deepin pr auto review

这段代码是一个对 QML 文件 SpeakerPage.qml 的修改,主要修改了字体样式。以下是对这段代码的审查意见:

1. 语法逻辑

  • 语法正确:代码语法符合 QML 规范,属性赋值格式正确。
  • 逻辑合理:将 DTK.fontManager.t4 修改为 DTK.fontManager.t8,这通常意味着调整了文本的字体大小或样式。从上下文来看,这是用于显示"未找到输出设备"的提示文本,调整字体大小可能更符合 UI 设计规范。

2. 代码质量

  • 可读性:代码结构清晰,属性排列整齐,易于阅读。
  • 命名规范DTK.fontManager.t8 的命名符合 DTK(Deepin Tool Kit)的规范,易于理解。

3. 代码性能

  • 性能影响:修改字体样式对性能的影响可以忽略不计,因为这只是静态属性的修改,不会引入额外的计算或渲染开销。

4. 代码安全

  • 安全性:此修改不涉及安全风险,仅调整了 UI 显示的字体样式。

5. 改进建议

  • 字体一致性:确保 DTK.fontManager.t8 与其他类似提示文本的字体样式保持一致,避免 UI 风格不统一。
  • 国际化qsTr("No output device for sound found") 是国际化文本,确保翻译文件中已更新对应的翻译。
  • 测试覆盖:建议在 UI 测试中验证字体大小是否合适,尤其是在不同分辨率和 DPI 设置下,确保文本不会过小或过大。

总结

这段代码修改是合理的,主要调整了字体样式以符合 UI 设计要求。建议在修改后进行 UI 测试,确保字体大小和样式在所有场景下都表现良好。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: electricface, fly602

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@electricface
Copy link
Member Author

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Feb 3, 2026

This pr force merged! (status: behind)

@deepin-bot deepin-bot bot merged commit 66362c4 into linuxdeepin:master Feb 3, 2026
16 of 18 checks passed
@electricface electricface deleted the swt/fix-bug300469 branch February 3, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants