Add check for non-inclusive language; Clean up / Workaround non-inclusive words#551
Conversation
|
[citest] |
|
I cannot reproduce the tests_network_state_nm-FAILED.log failure in RHEL-9.2.0-20230111.33/ansible-2.13/. The latest compose available is RHEL-9.2.0-20230116.28. Could it be the issue? |
| - Use inclusive language | ||
| - `slave` is deprecated in favor of `port` | ||
| - `master` is deprecated in favor of `controller` | ||
| - `slave` is deprecated in favor of `port` <!--- wokeignore:rule=slave --> |
There was a problem hiding this comment.
The subject line of this PR may need to be properly adjusted. Because the changes are about workarounding the woke non-inclusive language failure with the wokeignore: rule=* comment.
nhosoi
changed the title
- CHANGELOG.md - README.md - contributing.md - library/network_connections.py - module_utils/network_lsr/argument_validator.py - module_utils/network_lsr/ethtool.py - tests/ensure_provider_tests.py - tests/playbooks/tests_bond_options.yml - tests/unit/test_network_connections.py Signed-off-by: Noriko Hosoi <nhosoi@redhat.com>
Add a check for usage of terms and language that is considered non-inclusive. We are using the woke tool for this with a wordlist that can be found at https://github.com/linux-system-roles/tox-lsr/blob/main/src/tox_lsr/config_files/woke.yml Note: this commit uses the customized woke placed locally in .github/actions/custom-woke-action to support a new option --count-only-error-for-failure option. The local action custom-woke-action will be replaced with the official woke once get-woke/woke#252 (Add an option "--count-only-error-for-failure") is processed. Signed-off-by: Noriko Hosoi <nhosoi@redhat.com>
|
@liangwen12year, it seems the with in library/network_connections.py and module_utils/network_lsr/argument_validator.py. Could you please review this pr one more time? Thanks! |
liangwen12year
left a comment
liangwen12year
left a comment
There was a problem hiding this comment.
LGTM now. Thanks.
ready to merge? |
I think so unless we are supposed to figure out this failure... |
No, not related.
|
|
@liangwen12year, if ok, could you please merge this pr? Thanks! |
4 participants
Add check for non-inclusive language
Add a check for usage of terms and language that is considered non-inclusive. We are using the woke tool for this with a wordlist that can be found at
https://github.com/linux-system-roles/tox-lsr/blob/main/src/tox_lsr/config_files/woke.yml
Note: this commit uses the customized woke placed locally in .github/actions/custom-woke-action to support a new option
--count-only-error-for-failureoption. The local action custom-woke-action will be replaced with the official woke once get-woke/woke#252 (Add an option "--count-only-error-for-failure") is processed.Clean up / Workaround non-inclusive words.
Additional note: There are too many warning level words
masteranddumpto skip with# wokeignore:rule=word. So, I use the customized woke to skip the warning words in this PR. The# wokeignore:rule=wordis mainly applied to the error level wordslave(and warning level words in the python codes).