Add check for non-inclusive language#91
Merged
richm merged 2 commits intolinux-system-roles:masterfrom Jan 4, 2023
Merged
Conversation
Add a check for usage of terms and language that is considered non-inclusive. We are using the woke tool for this with a wordlist that can be found at https://github.com/linux-system-roles/tox-lsr/blob/main/src/tox_lsr/config_files/woke.yml Signed-off-by: Noriko Hosoi <nhosoi@redhat.com>
- CHANGELOG.md - README.md - library/nbde_client_clevis.py - tests/tasks/cleanup_test.yml Ignore "the LUKS master key" by wokeignore:rule=master in library/nbde_client_clevis.py.
Contributor
|
lgtm - @sergio-correia ? |
Member
|
LGTM as well. Apologies for the delay, I missed this one. |
sergio-correia
approved these changes
Jan 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a check for usage of terms and language that is considered
non-inclusive. We are using the woke tool for this with a wordlist
that can be found at
https://github.com/linux-system-roles/tox-lsr/blob/main/src/tox_lsr/config_files/woke.yml
Clean up non-inclusive words.
Note:
masteris left in nbde_client_clevis.py as follows, which causes the non-inclusive language check action fails.There are three ways to fix it - 1) replacing
LUKS master keywith a phrase that does not includemasteror 2) leavingLUKS master keyas it is and applying get-woke/woke#252 that allows the warning level severity or 3) ignoring "the LUKS master key" by wokeignore:rule=master.I've updated the pr using (3) as seen at https://github.com/linux-system-roles/nbde_client/pull/91/files#diff-fcb01b85ce6e35eb2f419f284a8ac712d435336b141a96ec73a2a03edade7f5aR1003, which makes the woke test pass. Is it ok?