ci: tox-lsr 3.17.1 - previous update broke container tests, this fixes them [citest_skip]#244
Merged
ci: tox-lsr 3.17.1 - previous update broke container tests, this fixes them [citest_skip]#244
Conversation
…s them [citest_skip] tox-lsr 3.17.1 has a fix for the broken container tests There was one shell function for both setting up the callback plugins and the connection plugin. When this function was skipped, the ANSIBLE_CONNECTION_PLUGINS environment variable was not set, so all subsequent tests failed. The connection plugin must be present and the env. var. must be set in order to run any container tests. The code was fixed to ensure that there is always a connection plugin installed in the correct location and that ANSIBLE_CONNECTION_PLUGINS is always set and contains this path. Also, setting up the callback plugins and the connection plugin is already idempotent, so no reason to skip them. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates CI workflows to use tox-lsr 3.17.1 (which fixes broken container tests) and stops skipping callback/connection plugin setup between test runs so the required Ansible connection plugin environment is always present. Sequence diagram for CI job ensuring Ansible connection plugin is available with tox_lsr_3_17_1sequenceDiagram
participant Workflow as GithubActionsWorkflow
participant Runner as CIJobRunner
participant Pip as PipInstaller
participant Tox as Tox
participant ToxLsr as ToxLsr_3_17_1
participant Ansible as Ansible
participant FS as Filesystem
participant Env as Environment
participant CTests as ContainerTests
Workflow->>Runner: Trigger job (push or PR)
Runner->>Pip: pip3 install git+https://github.com/linux_system_roles/tox_lsr@3.17.1
Pip-->>Runner: tox_lsr 3.17.1 installed
Runner->>Tox: tox run container test environment
Tox->>ToxLsr: Initialize test environment
ToxLsr->>FS: Install connection plugin in known path
ToxLsr->>FS: Install callback plugins (idempotent)
ToxLsr->>Env: Set ANSIBLE_CONNECTION_PLUGINS to connection plugin path
ToxLsr-->>Tox: Environment prepared
Tox->>Ansible: Execute container based test playbooks
Ansible->>CTests: Run tests using connection plugin
CTests-->>Ansible: Test results
Ansible-->>Tox: Test success or failure
Tox-->>Runner: Exit code and logs
Runner-->>Workflow: Job status
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The tox-lsr version is hard-coded in multiple workflows; consider centralizing this (e.g., via a shared action, reusable workflow, or environment variable) so future version bumps only require a single change.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The tox-lsr version is hard-coded in multiple workflows; consider centralizing this (e.g., via a shared action, reusable workflow, or environment variable) so future version bumps only require a single change.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tox-lsr 3.17.1 has a fix for the broken container tests
There was one shell function for both setting up the callback plugins and the connection plugin.
When this function was skipped, the ANSIBLE_CONNECTION_PLUGINS environment variable was not
set, so all subsequent tests failed. The connection plugin must be present and the env. var.
must be set in order to run any container tests. The code was fixed to ensure that there is
always a connection plugin installed in the correct location and that ANSIBLE_CONNECTION_PLUGINS
is always set and contains this path.
Also, setting up the callback plugins and the connection plugin is already idempotent, so no
reason to skip them.
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Update CI workflows to use tox-lsr 3.17.1 and adjust test environment flags to restore container test execution.
Build:
CI: