ci: tox-lsr 3.17.0 - container test improvements, use ansible 2.20 for fedora 43 [citest_skip]

[richm]

tox-lsr 3.17.0 has some container test improvements - better output, faster runs

Use Ansible 2.20 for qemu/container tests on fedora 43

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use tox-lsr 3.17.0 and Ansible 2.20 for Fedora 43 test scenarios, improving container test efficiency and output.

CI:

• Bump tox-lsr from 3.16.0 to 3.17.0 across GitHub Actions workflows for integration, lint, ansible tests, and Python unit tests.
• Adjust Fedora 43 qemu and container test scenarios to run with Ansible Core 2.20 instead of 2.19.
• Optimize container test job loop by running full setup only on the first test and skipping requirements and callback plugin setup on subsequent runs.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI workflows to use tox-lsr 3.17.0 and Ansible 2.20 for Fedora 43, and adjusts container test environment variables to speed up runs while keeping the first run fully configured.

File-Level Changes

Change	Details	Files
Bump tox-lsr from 3.16.0 to 3.17.0 across GitHub Actions workflows.	Update qemu-kvm integration workflow to install tox-lsr 3.17.0 via pip from the linux-system-roles GitHub repository. Update ansible-lint workflow to install tox-lsr 3.17.0. Update ansible-managed-var-comment workflow to install tox-lsr 3.17.0. Update ansible-test workflow to install tox-lsr 3.17.0. Update python-unit-test workflow bootstrap to install tox-lsr 3.17.0 alongside tox and virtualenv.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml .github/workflows/python-unit-test.yml
Use Ansible Core 2.20 for Fedora 43 qemu and container test scenarios.	Change Fedora 43 qemu test matrix entry to use environment qemu-ansible-core-2-20 instead of 2-19. Change Fedora 43 container test matrix entry to use environment container-ansible-core-2-20 instead of 2-19. Change Fedora 43 bootc container test matrix entry to use environment container-ansible-core-2-20 instead of 2-19.	.github/workflows/qemu-kvm-integration-tests.yml
Adjust container test loop env vars to leverage new tox-lsr behavior for faster subsequent runs.	Remove previous LSR_CONTAINER_PROFILE and LSR_CONTAINER_PRETTY overrides before running container tests. Introduce SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS env vars, explicitly disabling skipping for the first tox run in the loop. After each test iteration, set SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS to true so that later tests in the loop can reuse setup and avoid repeated requirements and callback plugin handling.	.github/workflows/qemu-kvm-integration-tests.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The tox-lsr version string (3.17.0) is duplicated across several workflows; consider centralizing it via a reusable workflow or composite action so future bumps only need to be made in one place.
• In the container test loop, you now toggle SKIP_REQUIREMENTS/SKIP_CALLBACK_PLUGINS between the first and subsequent runs; it may be worth adding a brief comment explaining why only the first run must be full to avoid future confusion if the test layout changes.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The tox-lsr version string (3.17.0) is duplicated across several workflows; consider centralizing it via a reusable workflow or composite action so future bumps only need to be made in one place.
- In the container test loop, you now toggle SKIP_REQUIREMENTS/SKIP_CALLBACK_PLUGINS between the first and subsequent runs; it may be worth adding a brief comment explaining why only the first run must be full to avoid future confusion if the test layout changes.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}