ci: tox-lsr 3.16.0 - fix qemu tox test failures - rename to qemu-ansible-core-X-Y [citest_skip]

[richm]

the latest version of tox 4.49 has a strange issue - it thinks that a tox testenv
like [qemu-ansible-core-2.20] is specifying python 2.20 which conflicts with the
testenv basepython of python 3.latest. There appears to be no way to workaround this.

So, rename all of the testenvs to use major-minor instead of major.minor e.g.
[qemu-ansible-core-2-20]

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI tox-lsr version and align qemu/container test environment names with new tox constraints.

Bug Fixes:

• Adjust qemu and container tox environment identifiers to avoid tox misinterpreting ansible-core versions as Python versions.

CI:

• Bump tox-lsr in all GitHub workflows from 3.15.0 to 3.16.0 and update referenced qemu/container env names to the new major-minor naming scheme.

Documentation:

• Refresh contributing documentation example to use the new qemu tox environment name format.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI tox integration to work with tox 4.49 and tox-lsr 3.16.0 by renaming qemu/container ansible-core environments to use a dash-based major-minor suffix and bumping tox-lsr across all workflows, plus adjusting contributor docs to match.

Flow diagram for qemu tox environment name renaming

graph LR
  old_env[qemu-ansible-core-2.20] -->|renamed to avoid tox 4.49 python version conflict| new_env[qemu-ansible-core-2-20]

Loading

File-Level Changes

Change	Details	Files
Align tox environments and CI workflows with tox-lsr 3.16.0 and tox 4.49 naming expectations for qemu/container ansible-core testenvs.	Rename qemu ansible-core tox environment names from major.minor to major-minor in the qemu-kvm integration workflow matrix Rename container ansible-core tox environment names from major.minor to major-minor in the qemu-kvm integration workflow matrix, including commented scenarios Bump tox-lsr version from 3.15.0 to 3.16.0 in all GitHub Actions workflows that install it Update contributing documentation to reference the new qemu tox environment name pattern using dashes instead of dots	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml .github/workflows/python-unit-test.yml contributing.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The tox-lsr version string 3.16.0 is duplicated across several workflows; consider defining it in a single shared location (e.g., a reusable workflow, composite action, or environment variable) to make future upgrades less error-prone.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The tox-lsr version string `3.16.0` is duplicated across several workflows; consider defining it in a single shared location (e.g., a reusable workflow, composite action, or environment variable) to make future upgrades less error-prone.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}