Skip to content

DRAFT: Implement WRITE_LEASE_VALIDITY #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spetrosi wants to merge 1 commit into from
Closed

DRAFT: Implement WRITE_LEASE_VALIDITY #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,8 @@
__mssql_input_sql_file: create_ha_login.j2
include_tasks: input_sql_file.yml

# Required for configure_ag.j2 to set WRITE_LEASE_VALIDITY based on RHEL ver
# Required for configure_ag.j2 to set WRITE_LEASE_VALIDITY based on
# mssql-server version
- name: Get mssql-server version to see if WRITE_LEASE_VALIDITY is available
package_facts:
manager: auto
Expand Down
6 changes: 3 additions & 3 deletions templates/configure_ag.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,9 @@ IF NOT EXISTS (
BEGIN
PRINT 'Creating the {{ mssql_ha_ag_name }} availability group';
CREATE AVAILABILITY GROUP {{ mssql_ha_ag_name }}
{% if ansible_os_family == 'RedHat' and
ansible_distribution_version is version('8.3', '<') %}
WITH (DB_FAILOVER = ON, CLUSTER_TYPE = EXTERNAL)
{% if ansible_facts.packages['mssql-server'][0]['version']
is version('15.0.4153.1', '>=') %}
WITH (DB_FAILOVER = ON, CLUSTER_TYPE = EXTERNAL, WRITE_LEASE_VALIDITY=20)
{% else %}
WITH (DB_FAILOVER = ON, CLUSTER_TYPE = EXTERNAL)
{% endif %}
Expand Down
2 changes: 2 additions & 0 deletions tests/tests_configure_ha_cluster.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@
- attrs:
- name: notify
value: true
- name: on_fail
value: demote
ha_cluster_constraints_colocation:
- resource_leader:
id: ag_cluster-clone
Expand Down