Add check for non-inclusive language#132
Merged
nhosoi merged 2 commits intolinux-system-roles:mainfrom Jan 20, 2023
Merged
Conversation
nhosoi
requested review from
andreasgerstmayr,
natoscott,
richm and
sradco
as code owners
nhosoi
force-pushed
the
woke-action
branch
2 times, most recently
from
1981eff to
ca1a16f
Compare
Contributor
Author
|
[citest] |
richm
approved these changes
Jan 16, 2023
natoscott
requested changes
Jan 17, 2023
Collaborator
There was a problem hiding this comment.
@nhosoi thanks for looking into this - I'd be happy with switching to phrasing like 'confidence test' here instead of sanity, which would simplify this change I think? (edit: 'verify' like you used in ansible-pcp seems like an good alternative too).
Contributor
Author
|
[citest bad] |
Add a check for usage of terms and language that is considered non-inclusive. We are using the woke tool for this with a wordlist that can be found at https://github.com/linux-system-roles/tox-lsr/blob/main/src/tox_lsr/config_files/woke.yml Signed-off-by: Noriko Hosoi <nhosoi@redhat.com>
- Rename tests/tests_sanity_.*.yml to tests/tests_verify_.*.yml. - CHANGELOG.md - clean up non-inclusive words.
Contributor
Author
|
[citest] |
Contributor
Author
|
@natoscott, @richm, could there be anything else we should update this pr to make sure the inclusive language is ensured (=~ |
Contributor
Author
|
@natoscott, is it ok with you to merge this pr, too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a check for usage of terms and language that is considered
non-inclusive. We are using the woke tool for this with a wordlist
that can be found at
https://github.com/linux-system-roles/tox-lsr/blob/main/src/tox_lsr/config_files/woke.yml
CHANGELOG.md - cleanup non-inclusive words.
Note: The file name
tests/tests_sanity_*.ymlis preferable not to includesanityin it. We set the severity level ofsanitytowarningat https://github.com/linux-system-roles/tox-lsr/blob/main/src/tox_lsr/config_files/woke.yml#L59. So, they are not reported as an error for now. What should we do on this issue? Shall we leave them as they are or rename them to something else not includingsanity?Second note: To skip the warnings, we have to apply this patch (get-woke/woke#252) to
woke. Is it ok to do it in this pr?