test: add validation for hpc tuning#93
Open
lixuemin2016 wants to merge 1 commit intolinux-system-roles:mainfrom
Open
test: add validation for hpc tuning#93lixuemin2016 wants to merge 1 commit intolinux-system-roles:mainfrom
lixuemin2016 wants to merge 1 commit intolinux-system-roles:mainfrom
Conversation
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The usage text and examples in
test-tuning.sh.j2refer totest-hpc-tuning.sh, but the installed script is namedtest-tuning.sh; consider aligning the script name in the help output with the deployed filename. - The test messages include a typo (
availabilein the azsec-monitor check); updating these strings will make the output clearer and more professional. - Several tests hard-code configuration paths and expected values (limits, sysctl, udev rules); you may want to template these from the same Ansible variables used to configure the system to avoid drift between the role configuration and the validation script.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The usage text and examples in `test-tuning.sh.j2` refer to `test-hpc-tuning.sh`, but the installed script is named `test-tuning.sh`; consider aligning the script name in the help output with the deployed filename.
- The test messages include a typo (`availabile` in the azsec-monitor check); updating these strings will make the output clearer and more professional.
- Several tests hard-code configuration paths and expected values (limits, sysctl, udev rules); you may want to template these from the same Ansible variables used to configure the system to avoid drift between the role configuration and the validation script.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
richm
reviewed
Mar 5, 2026
templates/test-tuning.sh.j2
Outdated
| # ------------------------------------------------------------------------------ | ||
| # Test: Package Removal (azsec-monitor) | ||
| # ------------------------------------------------------------------------------ | ||
| availabile |
Contributor
There was a problem hiding this comment.
Suggested change
| availabile | |
| available |
Add validation tests for system tuning configurations: - Add test for security limits configuration - Check systemd DefaultLimitMEMLOCK configuration - Check kernel module sunrpc is installed or not - Validate sysctl tuning parameters JIRA: RHELHPC-122 Signed-off-by: Xuemin Li <xuli@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhancement:
Add validation tests for system tuning configurations:
Reason:
Add tests for system tuning configurations
Result:
`bash test-tuning.sh
[2026-03-05 12:01:56] ==========================================================
[2026-03-05 12:01:56] HPC System Tuning Validation Test
[2026-03-05 12:01:56] ==========================================================
[2026-03-05 12:01:56] Test: Unwanted package azsec-monitor availability...
[PASS] azsec-monitor package is not available as expected
[2026-03-05 12:01:56] Test: Security limits configuration...
[PASS] Security limits configured correctly
[2026-03-05 12:01:56] Test: Systemd memory lock configuration...
[PASS] Systemd DefaultLimitMEMLOCK configured correctly
[2026-03-05 12:01:56] Test: kernel module sunrpc ...
[PASS] sunrpc module configured correctly
[2026-03-05 12:01:56] Test: Sysctl tuning configuration...
[PASS] Sysctl parameters configured correctly
[2026-03-05 12:01:56] Test: NFS readahead udev rules...
[PASS] NFS readahead udev rules configured correctly
[2026-03-05 12:01:56] ==========================================================
[2026-03-05 12:01:56] All tests passed (6)
[2026-03-05 12:01:56] ==========================================================`
Issue Tracker Tickets (Jira or BZ if any):
JIRA: RHELHPC-122
Summary by Sourcery
Add an HPC system tuning validation script and install it as part of the role.
Tests: