Skip to content

fix: correct typo in service running test#92

Merged
richm merged 1 commit intolinux-system-roles:mainfrom
dgchinner:sku-fixes
Mar 5, 2026
Merged

fix: correct typo in service running test#92
richm merged 1 commit intolinux-system-roles:mainfrom
dgchinner:sku-fixes

Conversation

@dgchinner
Copy link
Collaborator

@dgchinner dgchinner commented Mar 5, 2026

e2e CI tests were failing because they detected the customisation service was not running like so:

/opt/hpc/azure/tests/test-sku-setup.sh
Job output:

Testing standard_nd40rs_v2
Failed: standard_nd40rs_v2: customisation service not running
FAILED [ 14%]

The service was running as it should, the test has a type in the service name it was checking, so it was checking for a service that didn't exist (and hence not running).

Jira: https://issues.redhat.com/browse/RHELHPC-176

Summary by Sourcery

Bug Fixes:

  • Fix end-to-end SKU setup test to check the correct systemd service name for the customisation service, preventing false test failures.

e2e CI tests were failing because they detected the customisation
service was not running like so:

 /opt/hpc/azure/tests/test-sku-setup.sh
 Job output:


 Testing standard_nd40rs_v2
 Failed: standard_nd40rs_v2: customisation service not running
FAILED [ 14%]

The service was running as it should, the test has a type in the
service name it was checking, so it was checking for a service that
didn't exist (and hence not running).

Jira: https://issues.redhat.com/browse/RHELHPC-176

Signed-off-by: Dave Chinner <dchinner@redhat.com>
@dgchinner dgchinner requested review from richm and spetrosi as code owners March 5, 2026 04:36
@sourcery-ai
Copy link

sourcery-ai bot commented Mar 5, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Fixes the e2e SKU setup test by correcting the systemd service name used to verify that the customisation service is running, so the test now checks the actual running service instead of a misspelled one.

File-Level Changes

Change Details Files
Corrected the systemd service name used in the SKU setup test so it checks the real customisation service instead of a non-existent one.
  • Updated the systemctl is-active invocation to use the correct sku_customisation unit name in the customisation-service running check
  • Kept the failure message and surrounding test logic unchanged to preserve existing behavior and reporting
templates/sku/test-sku-setup.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit ead73c5 into linux-system-roles:main Mar 5, 2026
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants