Open
Conversation
commit "d4dd187600 providers: add support for USDT tracing using libbpf/usdt" changed the make flags required for building with trace support but left out setting ENABLE_LTTNG in the main CMakeLists.txt. The provider CMakeLists.txt files check for both ENABLE_LTTNG and LTTNGUST_FOUND, but ENABLE_LTTNG was never set. Fix by setting it when TRACING=LTTNG is specified. Signed-off-by: Yehuda Yitschak <yehuday@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit "d4dd187600 providers: add support for USDT tracing using libbpf/usdt" changed the make flags required for building with trace support but left out setting ENABLE_LTTNG in the main CMakeLists.txt.
The provider CMakeLists.txt files check for both ENABLE_LTTNG and LTTNGUST_FOUND, but ENABLE_LTTNG was never set. Fix by setting it when TRACING=LTTNG is specified.
Change-Id: I168263ea7433d7d6eec434b9129e0f7cc2969890