Add RSCT Validate/Repair check in ServiceReport tool #15
Conversation
|
When I run this I see ; servicereport 2.2.2 RSCT configuration check FAIL IBM Power Repo Package check FAIL Manual Fix Needed install ibm-power-repo package, run /opt/ibm/lop/configure to agree with the license <-- Mix of upper and small case is not nice! Probably this should be added at the end .. RSCT Installation path FAIL -Vasant |
|
Thanks for the review @hegdevasant Will add instructions to install ibm-power-repo package.
|
The RSCT plugin performs following checks to validate RSCT configuations. 1. Check for RSCT installation path 2. Check for RSCT Package information 3. Check for RSCT Service check 4. Check for ibm-power-repo package The RSCT plugin performs following checks to repair RSCT configurations. 1. Repair and fix RSCT installation path 2. Repair and fix RSCT Package information if any of the RSCT package is missing 3. Repair and fix RSCT Service check if any of the RSCT services is down 4. Notifies/WARN user to enable and accept licensing for ibm-power-repo package if RSCT Packages is not available on the system. ibm-power-repo package needs to be enabled and accept licensing in order to install RSCT packages on the system More info on RSCT: https://www.ibm.com/support/knowledgecenter/SGVKBA_3.2/admin/bl503_ovrv.html https://www.ibm.com/support/pages/service-and-productivity-tools Signed-off-by: Seeteena Thoufeek <s1seetee@linux.vnet.ibm.com> Signed-off-by: Sourabh Jain <sourabhjain@linux.ibm.com>
|
Any update on this pull request? |
|
|
||
|
|
||
| def check_rsct_warning_check(self): | ||
| """IBM Power Repo Package Check""" |
There was a problem hiding this comment.
Consider renaming the function to a name that is more closely associated with the package check it is performing, as the current function name does not align with its intended purpose.
| return Check(self.check_rsct_installation_path.__doc__, | ||
| installation_path_exists) | ||
|
|
||
| def get_subsystem_status(self, subsystem): |
There was a problem hiding this comment.
Adding rsct in the function makes it more meaning full.
| subsys_list.append((subsystem, subsys_status)) | ||
| else: | ||
| subsys_status = True | ||
| subsys_list.append((subsystem, subsys_status)) |
There was a problem hiding this comment.
Let's have only one subsys_list.append call. Take it out from if and else.
The same goes for the RSCT package check.
| from servicereportpkg.validate.schemes.schemes import PSeriesScheme | ||
|
|
||
|
|
||
| class RSCT(Plugin, PSeriesScheme): |
There was a problem hiding this comment.
I hope that no changes are required if this plugin is executed on different distributions.
| # Author: Seeteena Thoufeek <s1seetee@linux.vnet.ibm.com> | ||
|
|
||
| """Plugin to repair the rsct configuration check""" | ||
|
|
There was a problem hiding this comment.
Consider adding RSCT full form at least once in the plugin and commit message.
| ibm-power-repo package. \n 1. Download and install ibm-power-repo package. \ | ||
| \n 2. run /opt/ibm/lop/configure to agree with the license. \ | ||
| \n Refer https://www.ibm.com/support/pages/service-and-productivity-tools \ | ||
| for more details") |
There was a problem hiding this comment.
Let's have a variable to store the above string.
3 participants
Signed-off-by: Seeteena Thoufeek s1seetee@linux.vnet.ibm.com