Make the lookup code private #3051
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the configuration update code to the library. Signed-off-by: Daniel Wagner <wagi@kernel.org>
There is no user for this, thus remove it. Signed-off-by: Daniel Wagner <wagi@kernel.org>
Replace the nvme_default_host function with a more generic nvme_host_get function which will create the host object if necessary. This also allows to retire the nvme_lookup_host function from the public API. Signed-off-by: Daniel Wagner <wagi@kernel.org>
Split the create host code into a separate function to explicitly document the create new object if it is not found. Signed-off-by: Daniel Wagner <wagi@kernel.org>
Replace the nvme_lookup_subsystem function with nvme_subsystem_get function which will create the host object if necessary. This allows to retire the nvme_lookup_host function from the public API. Signed-off-by: Daniel Wagner <wagi@kernel.org>
There are no public users for these function. Make them private so we can refactor them without breaking the API in future. Signed-off-by: Daniel Wagner <wagi@kernel.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After moving the update config away, it's possible to move the lookup function into the private section. It is still necessary to have a way to get a host or subsystem, thus introduce a couple new function. The motivation here is that we have the lookup function operate either on a host, subsystem or ctrl object. When object doesn't exist it will create one. We really want also the global context at creation time. Yes, we could add the global context to the lookup API but this seems a bit strange. Also I think it would be better to split these functionality in the future. Though at this point I don't wont to introduce regression. Thus a simple getter should to the trick