Add sparse matrix support for dot multiplication in function _sort_neighbourhood#8
Open
mrdrgz wants to merge 1 commit intolinnarsson-lab:masterfrom
Open
Add sparse matrix support for dot multiplication in function _sort_neighbourhood#8mrdrgz wants to merge 1 commit intolinnarsson-lab:masterfrom
mrdrgz wants to merge 1 commit intolinnarsson-lab:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I edited one of the functions in backSPIN to add sparse matrix support to the dot calculation. In my machine, I've noticed a substantial speed increase when running big, sparse matrices derived from DropSeq (from two weeks and unfinished run to 2-3 days with the new version). Using the test data included in the package, the run time is ~10 minutes faster and the output files identical.
I hope these changes help out other people :) It would be cool if it could be an optional feature, but I'm afraid I don't have the time to polish more the code.