Skip to content

Conversation

@KaiSernLim
Copy link
Contributor

@KaiSernLim KaiSernLim commented Dec 10, 2025

Problem Statement

We have lag-based metrics, but we don't understand ingestion progress during bootstrap.

Solution

For a position, calculate how far in the topic it is by dividing the current position by the end position. Add ingestion progress percentage in the following 3 scenarios:

  1. Topic subscription
  2. OffsetRecord sync to disk
  3. IngestionNotificationDispatcher reporting Push Statuses
INFO StoreIngestionTask Subscribed to: [store-name]_[version]-[partition] position: EARLIEST
INFO StoreIngestionTask Offset synced for replica: [store-name]_[version]-[partition] - localVtOffset: ApacheKafkaOffsetPosition{[offset]}
INFO IngestionNotificationDispatcher Reported END_OF_PUSH_RECEIVED to 3 notifiers for PartitionConsumptionState: PCS{...}

It is behind a new server config feature flag named positional.progress.logging.enabled.

Code changes

  • Added new code behind a config. If so list the config names and their default values in the PR description.
    Behind positional.progress.logging.enabled.
  • Introduced new log lines.
    • Confirmed if logs need to be rate limited to avoid excessive logging.

How was this PR tested?

  • New unit tests added.
    testGetIngestionProgressPercentage() in TopicManagerTest.

Does this PR introduce any user-facing or breaking changes?

  • No. You can skip the rest of this section.

@KaiSernLim KaiSernLim self-assigned this Dec 10, 2025
@KaiSernLim KaiSernLim changed the title Partition progress log [server] Partition Progress Log Dec 11, 2025
Copy link
Contributor

@sushantmane sushantmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, these logs are useful to have. When adding them, we need to ensure they don’t increase metadata query load on the servers, and that the additional requests don’t reduce or weaken ingestion path resiliency to metadata failures.

@KaiSernLim KaiSernLim force-pushed the partition-progress-log branch from c9e1182 to ca3a805 Compare January 5, 2026 19:34
Copy link
Contributor

@sushantmane sushantmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@KaiSernLim KaiSernLim enabled auto-merge (squash) January 6, 2026 21:49
@KaiSernLim KaiSernLim merged commit 138914e into linkedin:main Jan 6, 2026
50 checks passed
@KaiSernLim KaiSernLim deleted the partition-progress-log branch January 6, 2026 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants