-
Notifications
You must be signed in to change notification settings - Fork 113
[server] Partition Progress Log #2343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sushantmane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, these logs are useful to have. When adding them, we need to ensure they don’t increase metadata query load on the servers, and that the additional requests don’t reduce or weaken ingestion path resiliency to metadata failures.
...ts/da-vinci-client/src/main/java/com/linkedin/davinci/kafka/consumer/StoreIngestionTask.java
Outdated
Show resolved
Hide resolved
...ts/da-vinci-client/src/main/java/com/linkedin/davinci/kafka/consumer/StoreIngestionTask.java
Outdated
Show resolved
Hide resolved
...ts/da-vinci-client/src/main/java/com/linkedin/davinci/kafka/consumer/StoreIngestionTask.java
Outdated
Show resolved
Hide resolved
… the ingestion progress percentage. 🪴
c9e1182 to
ca3a805
Compare
internal/venice-common/src/main/java/com/linkedin/venice/ConfigKeys.java
Outdated
Show resolved
Hide resolved
sushantmane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Problem Statement
We have lag-based metrics, but we don't understand ingestion progress during bootstrap.
Solution
For a position, calculate how far in the topic it is by dividing the current position by the end position. Add ingestion progress percentage in the following 3 scenarios:
OffsetRecordsync to diskIngestionNotificationDispatcherreporting Push StatusesIt is behind a new server config feature flag named
positional.progress.logging.enabled.Code changes
Behind
positional.progress.logging.enabled.How was this PR tested?
testGetIngestionProgressPercentage()inTopicManagerTest.Does this PR introduce any user-facing or breaking changes?