Skip to content

Conversation

@m-nagarajan
Copy link
Contributor

Problem Statement

PR 2191 only disables tehuti metrics that are created via new Otel MetricEntityState APIs.

Solution

This PR disables tehuti metrics in AbstractVeniceStats.java by reusing a NoopSensor if tehuti is disabled. This sensor is not registered and every record() operation will be a Noop.

Code changes

  • Added new code behind a config. If so list the config names and their default values in the PR description.
  • Introduced new log lines.
    • Confirmed if logs need to be rate limited to avoid excessive logging.

Concurrency-Specific Checks

Both reviewer and PR author to verify

  • Code has no race conditions or thread safety issues.
  • Proper synchronization mechanisms (e.g., synchronized, RWLock) are used where needed.
  • No blocking calls inside critical sections that could lead to deadlocks or performance degradation.
  • Verified thread-safe collections are used (e.g., ConcurrentHashMap, CopyOnWriteArrayList).
  • Validated proper exception handling in multi-threaded code to avoid silent thread termination.

How was this PR tested?

  • New unit tests added.
  • New integration tests added.
  • Modified or extended existing tests.
  • Verified backward compatibility (if applicable).

Does this PR introduce any user-facing or breaking changes?

  • No. You can skip the rest of this section.
  • Yes. Clearly explain the behavior change and its impact.

lluwm
lluwm previously approved these changes Oct 21, 2025
Copy link
Contributor

@lluwm lluwm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @m-nagarajan!

@m-nagarajan m-nagarajan merged commit 661bafd into linkedin:main Oct 29, 2025
50 checks passed
arjun4084346 pushed a commit to arjun4084346/venice that referenced this pull request Dec 9, 2025
…inkedin#2224)

Disables tehuti metrics in AbstractVeniceStats.java by reusing a NoopSensor if tehuti is disabled. This sensor is not registered and every record() operation will be a Noop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants