feat: implement dynamic builtin module detection (fixes #50)#51
Open
feat: implement dynamic builtin module detection (fixes #50)#51
Conversation
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #50
Replaces hardcoded supportedBuiltins list with dynamic detection using Node.js module.isBuiltin() API. This change: - Uses module.isBuiltin() (Node.js 18.6.0+) for dynamic detection - Falls back to module.builtinModules for older Node.js versions - Keeps special handling only for modules that need it: - Browser polyfills (console, crypto, url, performance) - Bun/Deno compatibility (fs/promises, process) - Special export handling (events, stream, buffer, assert) - Browser error messages (fs, path, os, etc.) Benefits: - Automatically supports all 70+ Node.js built-in modules - Future-proof: new modules are supported automatically - Smaller codebase with less maintenance burden - All existing tests continue to pass Adds tests for dynamically detected modules like tty, cluster, readline, string_decoder, timers, worker_threads, vm, and punycode. Fixes #50 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This reverts commit 3ca349a.
Member
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
Now working session is ended, feel free to review and add any feedback on the solution draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements dynamic built-in module detection using Node.js
module.isBuiltin()API, replacing the hardcodedsupportedBuiltinslist.Changes:
module.isBuiltin()(Node.js 18.6.0+) with fallback tomodule.builtinModulesfor older versionsdocs/case-studies/issue-50/README.mdBenefits:
Test plan
npm test)Fixes #50
🤖 Generated with Claude Code