Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions experiments/test-docker-pull-output.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
#!/usr/bin/env node
/**
* Test script to verify docker pull output format
* This test verifies that there is no empty line between
* the timeline marker and the virtual command line
*/

const {
createVirtualCommandBlock,
createVirtualCommandResult,
createTimelineSeparator,
} = require('../js/src/lib/output-blocks');

console.log('Testing virtual command output format...\n');

// Simulate what dockerPullImage does
const image = 'alpine:latest';

// Print the virtual command line (should NOT have empty line after)
const commandBlock = createVirtualCommandBlock(`docker pull ${image}`);
console.log(commandBlock);

// Expected: next line should be docker pull output, NOT an empty line
console.log('latest: Pulling from library/alpine');
console.log('f6b4fb944634: Pull complete');
console.log('Digest: sha256:865b95f46d98cf867a156fe4a135ad3fe50d2056aa3f25ed31662dff6da4eb62');
console.log('Status: Downloaded newer image for alpine:latest');
console.log('docker.io/library/alpine:latest');

// Print result marker and separator
console.log();
console.log(createVirtualCommandResult(true));
console.log(createTimelineSeparator());

console.log('\nβœ“ Test complete - verify no empty line after "$ docker pull alpine:latest"');
12 changes: 12 additions & 0 deletions js/.changeset/fix-visual-continuity-73.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
'start-command': patch
---

fix: Remove empty line after virtual command to maintain visual continuity

- Fixed visual continuity break in docker pull output
- Removed empty line between timeline marker (`β”‚`) and virtual command line (`$ docker pull`)
- Output now flows continuously from timeline marker to command to output
- Applies to all virtual command blocks (currently docker pull operations)

Fixes #73
1 change: 0 additions & 1 deletion js/src/lib/docker-utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ function dockerPullImage(image) {

// Print the virtual command line
console.log(createVirtualCommandBlock(`docker pull ${image}`));
console.log();

let output = '';
let success = false;
Expand Down
8 changes: 8 additions & 0 deletions rust/changelog.d/73.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
fix: Remove empty line after virtual command to maintain visual continuity

- Fixed visual continuity break in docker pull output
- Removed empty line between timeline marker (`β”‚`) and virtual command line (`$ docker pull`)
- Output now flows continuously from timeline marker to command to output
- Applies to all virtual command blocks (currently docker pull operations)

Fixes #73
1 change: 0 additions & 1 deletion rust/src/lib/isolation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,6 @@ pub fn docker_pull_image(image: &str) -> (bool, String) {
"{}",
crate::output_blocks::create_virtual_command_block(&format!("docker pull {}", image))
);
println!();

let mut child = match Command::new("docker")
.args(["pull", image])
Expand Down
Loading