fix: Gist URL capture and human-readable file size display#14
Merged
Conversation
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #13
- Fix gist URL not being captured due to empty string interpolation in command-stream template literal (issue #13) - Add formatFileSize() function for human-readable file sizes (e.g., "1.90 KB" instead of "0.00 MB") - Improve CLI output with better formatting and file info display - Add comprehensive tests for formatFileSize function - Add experiment scripts documenting the issue and solution Fixes #13 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Member
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
Now working session is ended, feel free to review and add any feedback on the solution draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gh gist createcommand was failing to capture the URL due to empty string interpolation issues in the command-stream template literal when creating private gistsformatFileSize()function that properly formats file sizes (e.g., "1.90 KB" instead of "0.00 MB" for small files)Root Cause Analysis
The issue was in
src/index.jsline 211-213:When
visibilitywas an empty string for private gists, the command-stream template literal interpreted this incorrectly, causing a shell pattern matching error (no matches found for \``) and losing the gist URL from stdout.Solution
Changed to use conditional command execution:
Changes Made
src/index.js: Fixed gist upload command, addedformatFileSize()functionsrc/cli.js: Improved CLI output with file info before uploadtest/index.test.js: Added 7 new tests forformatFileSizefunctionexperiments/: Added experiment scripts documenting the issue and solutionTest plan
Fixes #13
🤖 Generated with Claude Code