Add integration tests for StackOverflow page download with markdown and image support#12
Open
Add integration tests for StackOverflow page download with markdown and image support#12
Conversation
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: undefined
…down and image support This commit implements comprehensive integration tests to verify that both Puppeteer and Playwright engines can: - Download the StackOverflow page at https://stackoverflow.com/questions/927358/how-do-i-undo-the-most-recent-local-commits-in-git - Convert the page HTML to markdown format - Capture screenshots of the page as PNG images Changes: - Add StackOverflow download tests for both Puppeteer and Playwright engines in tests/integration/browser-engines.test.js - Update jest.config.mjs to include integration tests in testMatch pattern - Fix Playwright adapter's setUserAgent implementation to use route interception (Playwright doesn't have page.setUserAgent()) - Increase timeout for StackOverflow tests to 60000ms for navigation and 90000ms for test completion to handle slower page loads All tests pass successfully, confirming that both browser engines work correctly for downloading and processing complex real-world pages. Fixes #11 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This reverts commit c351428.
Collaborator
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 📎 Log file uploaded as GitHub Gist (277KB) Now working session is ended, feel free to review and add any feedback on the solution draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive integration tests to verify that both Puppeteer and Playwright browser engines can successfully download and process a real-world StackOverflow page, including:
Changes
New Tests (
tests/integration/browser-engines.test.js)Added test suite "StackOverflow Page Download" with tests for both engines:
Puppeteer Engine:
Playwright Engine:
The tests verify:
Configuration Updates
jest.config.mjs: Added**/tests/integration/**/*.test.jsto testMatch pattern to enable integration testsBug Fixes
src/browser.js: Fixed Playwright adapter'ssetUserAgentmethod. Playwright doesn't have apage.setUserAgent()method, so implemented it using route interception to modify request headersPerformance Tuning
Test Results
All 11 tests pass successfully:
Fixes
Fixes #11
🤖 Generated with Claude Code