fix: reset KV cache between generations to fix second message bug#8
Merged
fix: reset KV cache between generations to fix second message bug#8
Conversation
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #7
Root cause: The KV cache was persistent across multiple generate() calls, but each new message starts from position 0 with a new prompt, causing dimension mismatches when the cache contains values from the previous generation. Changes: - Reset KV cache at the beginning of each generate() call - Add proper handling for ChatML special tokens (<|im_end|>, <|im_start|>) - Support multiple EOS token types for SmolLM2-Instruct model - Implement automatic model download on page load (no button needed) - Add E2E test for multiple consecutive messages (issue #7) - Update initial welcome message to reflect automatic loading Fixes #7 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
Now working session is ended, feel free to review and add any feedback on the solution draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the critical issue where sending a second message to the SmolLM2 model would fail with:
Root Cause Analysis
The KV (Key-Value) cache in the LLaMA model was persistent across multiple
generate()calls. When a new message was sent:Changes
Bug Fixes:
generate()call to ensure clean state for new conversations<|im_end|>,<|im_start|>,<|endoftext|>)Features:
Tests:
Technical Details
The fix modifies
wasm/src/lib.rsto:_configtoconfigto make it accessible for cache recreationCacheinstance at the start of each generationTest Plan
cargo fmt --check)cannot broadcasterrors in consoleFixes #7
🤖 Generated with Claude Code