fix: skip fork creation when user owns the repository (issue #1206)#1235
Open
fix: skip fork creation when user owns the repository (issue #1206)#1235
Conversation
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #1206
When a user runs solve with --fork on their own repository, GitHub returns HTTP 403 because users cannot fork their own repos. Add owner detection in setupRepository that checks currentUser === owner before attempting any fork operations, returning early to work directly on the repository instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
konard
changed the title
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This reverts commit f218596.
Contributor
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
Now working session is ended, feel free to review and add any feedback on the solution draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setupRepository()to skip fork creation when the authenticated user owns the target repositoryHTTP 403: Resource not accessible by personal access tokenerror from GitHub when attempting to fork own repositoryRoot Cause
The
setupRepositoryfunction insrc/solve.repository.lib.mjsentered fork creation logic wheneverargv.forkwastrue, without checking if the current user is the repository owner. GitHub does not allow forking your own repositories and returns HTTP 403, causing solve to crash.The
--auto-forkpath insolve.mjswas not affected because it already checkspermissions.push/admin/maintainbefore enabling fork mode (owners always have admin access).Changes
src/solve.repository.lib.mjscurrentUser === ownercheck after retrieving current user, before fork conflict detectiontests/test-owner-fork-detection.mjsdocs/case-studies/issue-1206/README.md.changeset/fix-owner-fork-detection.mdTest Plan
node tests/test-owner-fork-detection.mjs)node tests/test-fork-parent-validation.mjs)Fixes #1206