Implemented word-lists generator from Wikivoyage categories#6
Open
Poslovitch wants to merge 2 commits intomasterfrom
Open
Implemented word-lists generator from Wikivoyage categories#6Poslovitch wants to merge 2 commits intomasterfrom
Poslovitch wants to merge 2 commits intomasterfrom
Conversation
Implements https://phabricator.wikimedia.org/T275297 Added missing properties in extension.json
Member
|
Poslovitch, since this new feature isn't within WikiValley mission I have no idea to who we could ask to test, accept, and deploy this PR. cc: @belett Also. You rocks. 😄 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements https://phabricator.wikimedia.org/T275297
Also added missing "default" properties in extension.json
IMPORTANT: this PR could not be tested locally. I'm in dire need of some documentation to install a MediaWiki instance on my end. We'll have to find someone able to test this PR.
BEFORE MERGING: Make sure to create a property on Lingua Libre. See the Phabricator task for more info about that.Done: lingua-libre/operations#3